Skip to content

cmake: add USES_TERMINAL to show cargo output #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

dario23
Copy link
Contributor

@dario23 dario23 commented Apr 2, 2025

Otherwise the CMake output is just stuck at the rust build step for
however long it takes to build.

Signed-Off-By: Johannes Schilling [email protected]

@dario23
Copy link
Contributor Author

dario23 commented Apr 2, 2025

@d3zd3z this is what should fix the issue we briefly touched on in today's Zephyr Rust status talk; marking it as draft because i can't test with my current environment.

Copy link
Collaborator

@d3zd3z d3zd3z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you get a chance, can you add to the other add custom command block. Also, the commit itself should have a Signed-off-by block at the end. See the other commits for more information. I think Zephyr guidelines also limit the length of lines in the commit text to 75 or so.

@d3zd3z
Copy link
Collaborator

d3zd3z commented Apr 2, 2025

Let me know, if you prefer, and I can just pull this change into some upcoming changes I have. I will need to have your full name for the email and the signed-off-by.

Or feel free to update it yourself.

@dario23 dario23 marked this pull request as ready for review April 2, 2025 22:15
@dario23
Copy link
Contributor Author

dario23 commented Apr 2, 2025

updated; also changed the commit description/first comment here, not sure what ends up in the commits in the end.

@d3zd3z
Copy link
Collaborator

d3zd3z commented Apr 4, 2025

I should try to get checkpatch running. @dario23 this is the current output. These should be easy to fix. You'll have to do:

$ git config user.name 'Johannes Schilling'
$ git commit --amend --reset-author

to get it to update the author. The rest are the styling and formatting.

You can use git commit ... -s to add the signed-off-by line automatically (it works with amend).

WARNING: Do not use whitespace before Signed-off-by:
#10: 
    Signed-Off-By: Johannes Schilling <[email protected]>

WARNING: 'Signed-off-by:' is the preferred signature form
#10: 
    Signed-Off-By: Johannes Schilling <[email protected]>

WARNING: Missing Signed-off-by: line by nominal patch author ''

total: 0 errors, 3 warnings, 14 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

It is complaining that the author doesn't match the signed off by (which can be fixed with the reset author), and about the capital O and B in the Sign-off-by.

Otherwise the CMake output is just stuck at the rust build step for
however long it takes to build.

Signed-off-by: Johannes Schilling <[email protected]>
Copy link
Member

@cfriedt cfriedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me - from what I gather, this should show incremental build progress as the rust compiler builds sources, right?

@d3zd3z d3zd3z merged commit e3518de into zephyrproject-rtos:main Apr 8, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants