-
Notifications
You must be signed in to change notification settings - Fork 32
cmake: add USES_TERMINAL to show cargo output #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@d3zd3z this is what should fix the issue we briefly touched on in today's Zephyr Rust status talk; marking it as draft because i can't test with my current environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you get a chance, can you add to the other add custom command block. Also, the commit itself should have a Signed-off-by
block at the end. See the other commits for more information. I think Zephyr guidelines also limit the length of lines in the commit text to 75 or so.
Let me know, if you prefer, and I can just pull this change into some upcoming changes I have. I will need to have your full name for the email and the signed-off-by. Or feel free to update it yourself. |
updated; also changed the commit description/first comment here, not sure what ends up in the commits in the end. |
I should try to get checkpatch running. @dario23 this is the current output. These should be easy to fix. You'll have to do:
to get it to update the author. The rest are the styling and formatting. You can use
It is complaining that the author doesn't match the signed off by (which can be fixed with the reset author), and about the capital O and B in the Sign-off-by. |
Otherwise the CMake output is just stuck at the rust build step for however long it takes to build. Signed-off-by: Johannes Schilling <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me - from what I gather, this should show incremental build progress as the rust compiler builds sources, right?
Otherwise the CMake output is just stuck at the rust build step for
however long it takes to build.
Signed-Off-By: Johannes Schilling [email protected]