Fix CI problem with doc generation #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
approved these changes
Apr 12, 2025
The `new` method on `ZephyrObject` changed to `new_raw`, but this doc comment was not updated. Fix. Signed-off-by: David Brown <[email protected]>
For normal builds, the offsets.h file gets generated before the Rust target builds. But, when trying to build just the docs, the dependency is not explicit, and the file is just not generated. Fix this by making the dependency explicit. Like the others, we can't use the top-level define name, and have to state the dependency target by expanded name. This is due to the "fascinating" scoping rules in cmake. Signed-off-by: David Brown <[email protected]>
Now that the work-q based futures have been removed, remove lingering documentation references to this functionality. Signed-off-by: David Brown <[email protected]>
d3zd3z
changed the title
cfriedt
approved these changes
Apr 15, 2025
teburd
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the 'rustdoc' cmake target to have proper dependencies, so that it can be built without having done a full build first.
In addition, fix some documentation warnings that have shown up with the doc runs not having been run.