Skip to content

Commit 0d796ee

Browse files
Aiman Mazlannashif
authored andcommitted
drivers: sensor: st: vl53l1x: add return to attr_set and attr_get
Incorrect value set by user when using sensor_attr_set can fail silently since it always returns 0. Fix by adding ret. Also added return on sensor_attr_get. Signed-off-by: Aiman Mazlan <[email protected]>
1 parent 3382e28 commit 0d796ee

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

drivers/sensor/st/vl53l1x/vl53l1.c

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -375,15 +375,17 @@ static int vl53l1x_attr_get(const struct device *dev,
375375
{
376376
__ASSERT_NO_MSG(chan == SENSOR_CHAN_DISTANCE);
377377

378+
int ret;
379+
378380
if (attr == SENSOR_ATTR_CONFIGURATION) {
379-
vl53l1x_get_mode(dev, val);
381+
ret = vl53l1x_get_mode(dev, val);
380382
} else if (attr == SENSOR_ATTR_CALIB_TARGET) {
381-
vl53l1x_get_roi(dev, val);
383+
ret = vl53l1x_get_roi(dev, val);
382384
} else {
383385
return -ENOTSUP;
384386
}
385387

386-
return 0;
388+
return ret;
387389
}
388390

389391
static int vl53l1x_attr_set(const struct device *dev,
@@ -393,15 +395,17 @@ static int vl53l1x_attr_set(const struct device *dev,
393395
{
394396
__ASSERT_NO_MSG(chan == SENSOR_CHAN_DISTANCE);
395397

398+
int ret;
399+
396400
if (attr == SENSOR_ATTR_CONFIGURATION) {
397-
vl53l1x_set_mode(dev, val);
401+
ret = vl53l1x_set_mode(dev, val);
398402
} else if (attr == SENSOR_ATTR_CALIB_TARGET) {
399-
vl53l1x_set_roi(dev, val);
403+
ret = vl53l1x_set_roi(dev, val);
400404
} else {
401405
return -ENOTSUP;
402406
}
403407

404-
return 0;
408+
return ret;
405409
}
406410

407411
static const struct sensor_driver_api vl53l1x_api_funcs = {

0 commit comments

Comments
 (0)