net: conn: Use safe slist macro when searching connection

jukkar · nashif · commit 28177dad6fa3 · 2020-09-18T22:07:53.000-04:00
Try to catch simultaneous insert to/delete from list when
searching the connection.

Signed-off-by: Jukka Rissanen &lt;jukka.rissanen@linux.intel.com&gt;
diff --git a/subsys/net/ip/connection.c b/subsys/net/ip/connection.c
@@ -149,8 +149,9 @@ static struct net_conn *conn_find_handler(uint16_t proto, uint8_t family,
 					  uint16_t local_port)
 {
 	struct net_conn *conn;
+	struct net_conn *tmp;
 
-	SYS_SLIST_FOR_EACH_CONTAINER(&conn_used, conn, node) {
+	SYS_SLIST_FOR_EACH_CONTAINER_SAFE(&conn_used, conn, tmp, node) {
 		if (conn->proto != proto) {
 			continue;
 		}

Original file line number	Diff line number	Diff line change
`@@ -149,8 +149,9 @@ static struct net_conn *conn_find_handler(uint16_t proto, uint8_t family,`
`149`	`149`	`uint16_t local_port)`
`150`	`150`	`{`
`151`	`151`	`struct net_conn *conn;`
	`152`	`+ struct net_conn *tmp;`
`152`	`153`
`153`		`- SYS_SLIST_FOR_EACH_CONTAINER(&conn_used, conn, node) {`
	`154`	`+ SYS_SLIST_FOR_EACH_CONTAINER_SAFE(&conn_used, conn, tmp, node) {`
`154`	`155`	`if (conn->proto != proto) {`
`155`	`156`	`continue;`
`156`	`157`	`}`