drivers: can: sja1000: remove excessive debug logging

henrikbrixandersen · jhedberg · commit 410c02ac57e2 · 2023-10-06T17:43:36.000+03:00
Remove excessive debug logging from the SJA1000 driver backend. Logging
each register access makes generic CAN debug logging unusable.

Signed-off-by: Henrik Brix Andersen &lt;hebad@vestas.com&gt;
diff --git a/drivers/can/can_sja1000.c b/drivers/can/can_sja1000.c
@@ -23,19 +23,14 @@ static inline void can_sja1000_write_reg(const struct device *dev, uint8_t reg,
 {
 	const struct can_sja1000_config *config = dev->config;
 
-	LOG_DBG("write reg %d = 0x%02x", reg, val);
 	return config->write_reg(dev, reg, val);
 }
 
 static inline uint8_t can_sja1000_read_reg(const struct device *dev, uint8_t reg)
 {
 	const struct can_sja1000_config *config = dev->config;
-	uint8_t val;
 
-	val = config->read_reg(dev, reg);
-	LOG_DBG("read reg %d = 0x%02x", reg, val);
-
-	return val;
+	return config->read_reg(dev, reg);
 }
 
 static inline int can_sja1000_enter_reset_mode(const struct device *dev)

Original file line number	Diff line number	Diff line change
`@@ -23,19 +23,14 @@ static inline void can_sja1000_write_reg(const struct device *dev, uint8_t reg,`
`23`	`23`	`{`
`24`	`24`	`const struct can_sja1000_config *config = dev->config;`
`25`	`25`
`26`		`- LOG_DBG("write reg %d = 0x%02x", reg, val);`
`27`	`26`	`return config->write_reg(dev, reg, val);`
`28`	`27`	`}`
`29`	`28`
`30`	`29`	`static inline uint8_t can_sja1000_read_reg(const struct device *dev, uint8_t reg)`
`31`	`30`	`{`
`32`	`31`	`const struct can_sja1000_config *config = dev->config;`
`33`		`- uint8_t val;`
`34`	`32`
`35`		`- val = config->read_reg(dev, reg);`
`36`		`- LOG_DBG("read reg %d = 0x%02x", reg, val);`
`37`		`-`
`38`		`- return val;`
	`33`	`+ return config->read_reg(dev, reg);`
`39`	`34`	`}`
`40`	`35`
`41`	`36`	`static inline int can_sja1000_enter_reset_mode(const struct device *dev)`