Skip to content

Commit 61095cd

Browse files
ParthibanI17164cfriedt
authored andcommitted
drivers: ethernet: phy: microchip_t1s: always reschedule phy_monitor_work
Previously, phy_monitor_work_handler() would return early without rescheduling the delayed work if the callback (cb) was not set, causing the periodic monitoring to stop. This change ensures that k_work_reschedule() is always called, even when cb is NULL, so monitoring of the PHY state continues. This prevents the monitor from being inadvertently stopped and ensures consistent behavior regardless of callback registration. This issue was observed during testing with the evb-lan8670-rmii (an external LAN8670 PHY) connected to the SAME54 Curiosity Ultra platform. Signed-off-by: Parthiban Veerasooran <[email protected]>
1 parent 893eea6 commit 61095cd

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/ethernet/phy/phy_microchip_t1s.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -254,6 +254,7 @@ static void phy_monitor_work_handler(struct k_work *work)
254254
const struct device *dev = data->dev;
255255

256256
if (!data->cb) {
257+
k_work_reschedule(&data->phy_monitor_work, K_MSEC(CONFIG_PHY_MONITOR_PERIOD));
257258
return;
258259
}
259260

0 commit comments

Comments
 (0)