espi: Fix gpio_manage_callback() logic

finikorg · fabiobaltieri · commit a657abae232e · 2022-10-04T14:10:05.000Z
espi_manage_callback() returns -EINVAL if it could not remove
callback. However if the list is empty success is returned when trying
to remove callback.

Signed-off-by: Andrei Emeltchenko &lt;andrei.emeltchenko@intel.com&gt;
diff --git a/drivers/espi/espi_utils.h b/drivers/espi/espi_utils.h
@@ -32,6 +32,8 @@ static inline int espi_manage_callback(sys_slist_t *callbacks,
 				return -EINVAL;
 			}
 		}
+	} else if (!set) {
+		return -EINVAL;
 	}
 
 	if (set) {

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,8 @@ static inline int espi_manage_callback(sys_slist_t *callbacks,`
`32`	`32`	`return -EINVAL;`
`33`	`33`	`}`
`34`	`34`	`}`
	`35`	`+ } else if (!set) {`
	`36`	`+ return -EINVAL;`
`35`	`37`	`}`
`36`	`38`
`37`	`39`	`if (set) {`