tests: posix: fs: declare entry statically

cfriedt · kartben · commit c0e0fc5d7f7f · 2025-01-08T01:29:06.000+01:00
qemu_x86/atom was failing tests/posix/fs in
test_fs_readdir_threadsafe for some reason and only for that
platform.

All other platforms pass the testsuite properly with the dirent
declared on the stack.

Declare the dirent object statically so that qemu_x86/atom will
pass test cases.

Signed-off-by: Chris Friedt &lt;cfriedt@tenstorrent.com&gt;
diff --git a/tests/posix/fs/src/test_fs_dir.c b/tests/posix/fs/src/test_fs_dir.c
@@ -54,7 +54,8 @@ static int test_mkdir(void)
 static struct dirent *readdir_wrap(DIR *dirp, bool thread_safe)
 {
 	if (thread_safe) {
-		struct dirent entry;
+		/* cannot declare on stack otherwise this test fails for qemu_x86/atom */
+		static struct dirent entry;
 		struct dirent *result = NULL;
 
 		zassert_ok(readdir_r(dirp, &entry, &result));

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,8 @@ static int test_mkdir(void)`
`54`	`54`	`static struct dirent readdir_wrap(DIR dirp, bool thread_safe)`
`55`	`55`	`{`
`56`	`56`	`if (thread_safe) {`
`57`		`- struct dirent entry;`
	`57`	`+ /* cannot declare on stack otherwise this test fails for qemu_x86/atom */`
	`58`	`+ static struct dirent entry;`
`58`	`59`	`struct dirent *result = NULL;`
`59`	`60`
`60`	`61`	`zassert_ok(readdir_r(dirp, &entry, &result));`