Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions boards/nordic/nrf54h20dk/nrf54h20dk_nrf54h20-ipc_conf.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,18 @@

/ {
ipc {
cpusec_cpuapp_event_report: event-report-1-2 {
compatible = "vnd,mbox-consumer";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think vnd,mbox-consumer was introduced for tests, not boards.

mboxes = <&cpuapp_bellboard 1>;
mbox-names = "event_channel";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered placing this under the cpusec_cpuapp_ipc node? I was imagining we could replace the nordic,ironside-call binding with something that captures all communication with IronSide:

cpusec_cpuapp_ipc: ipc-1-2 {
	compatible = "nordic,ironside-ipc";
	memory-regions = <&cpusec_cpuapp_ipc_shm>,
			 <&cpuapp_ironside_se_event_report>;
	memory-region-names = "call", "event";
	mboxes = <&cpusec_bellboard 12>,
		 <&cpuapp_bellboard 0>,
		 <&cpuapp_bellboard 1>;
	mbox-names = "call_tx", "call_rx", "event";
};

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds like a good idea, I'll make a suggestion for it and update the PR.

};

cpusec_cpurad_event_report: event-report-1-3 {
compatible = "vnd,mbox-consumer";
mboxes = <&cpurad_bellboard 1>;
mbox-names = "event_channel";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

event_signal? Not sure about the naming

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

event should be sufficient

};

cpusec_cpuapp_ipc: ipc-1-2 {
compatible = "nordic,ironside-call";
status = "disabled";
Expand Down
3 changes: 2 additions & 1 deletion boards/nordic/nrf54h20dk/nrf54h20dk_nrf54h20_cpuapp.dts
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,13 @@
interrupt-names = "irq0";
/* irq0:
* - 0: cpuapp-cpusec
* - 1: cpuapp-cpusec
* - 6: cpuapp-cpusys
* - 13: cpuapp-cpuppr
* - 14: cpuapp-cpuflpr
* - 18: cpuapp-cpurad
*/
nordic,interrupt-mapping = <0x00046041 0>;
nordic,interrupt-mapping = <0x00046043 0>;
};

&cpurad_bellboard {
Expand Down
4 changes: 2 additions & 2 deletions boards/nordic/nrf54h20dk/nrf54h20dk_nrf54h20_cpurad.dts
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
status = "okay";
interrupts = <96 NRF_DEFAULT_IRQ_PRIORITY>;
interrupt-names = "irq0";
/* irq0: 0: cpurad-cpusec, 6: cpurad-cpusys, 12: cpurad-cpuapp */
nordic,interrupt-mapping = <0x00001041 0>;
/* irq0: 0: cpurad-cpusec, 1: cpurad-cpusec, 6: cpurad-cpusys, 12: cpurad-cpuapp */
nordic,interrupt-mapping = <0x00001043 0>;
};

&cpuapp_bellboard {
Expand Down
Loading