Skip to content

tests: Bluetooth: Tester: Fix bad BIS sync shift #100533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −12
Open

tests: Bluetooth: Tester: Fix bad BIS sync shift #100533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions tests/bluetooth/tester/src/audio/btp_bap_broadcast.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@

static inline struct btp_bap_broadcast_stream *stream_bap_to_broadcast(struct bt_bap_stream *stream)
{
return CONTAINER_OF(CONTAINER_OF(CONTAINER_OF(stream, struct bt_cap_stream, bap_stream),

Check warning on line 60 in tests/bluetooth/tester/src/audio/btp_bap_broadcast.c

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

use of GNU statement expression extension from macro expansion 


See more on https://sonarcloud.io/project/issues?id=zephyrproject-rtos_zephyr&issues=AZrp692QOIKcMcImzRbR&open=AZrp692QOIKcMcImzRbR&pullRequest=100533
struct btp_bap_audio_stream, cap_stream),
struct btp_bap_broadcast_stream, audio_stream);
}
Expand All @@ -69,7 +69,7 @@

uint8_t btp_bap_broadcast_local_source_idx_get(struct btp_bap_broadcast_local_source *source)
{
return ARRAY_INDEX(local_sources, source);

Check warning on line 72 in tests/bluetooth/tester/src/audio/btp_bap_broadcast.c

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

use of GNU statement expression extension from macro expansion 


See more on https://sonarcloud.io/project/issues?id=zephyrproject-rtos_zephyr&issues=AZrp692QOIKcMcImzRbS&open=AZrp692QOIKcMcImzRbS&pullRequest=100533
}

struct btp_bap_broadcast_local_source *
Expand Down Expand Up @@ -1680,12 +1680,6 @@
struct bt_bap_bass_subgroup *subgroup = &delegator_subgroups[i];

subgroup->bis_sync = sys_get_le32(ptr);
if (subgroup->bis_sync != BT_BAP_BIS_SYNC_NO_PREF) {
/* For semantic purposes Zephyr API uses BIS Index bitfield
* where BIT(1) means BIS Index 1
*/
subgroup->bis_sync <<= 1;
}

ptr += sizeof(subgroup->bis_sync);
subgroup->metadata_len = *ptr;
Expand Down Expand Up @@ -1751,12 +1745,6 @@
struct bt_bap_bass_subgroup *subgroup = &delegator_subgroups[i];

subgroup->bis_sync = sys_get_le32(ptr);
if (subgroup->bis_sync != BT_BAP_BIS_SYNC_NO_PREF) {
/* For semantic purposes Zephyr API uses BIS Index bitfield
* where BIT(1) means BIS Index 1
*/
subgroup->bis_sync <<= 1;
}

ptr += sizeof(subgroup->bis_sync);
subgroup->metadata_len = *ptr;
Expand Down
Loading