tests: riscv: pmp: Make permission change tests dynamic #100709
+35
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: RISCV
zephyrbot
requested review from
VynDragon,
edersondisouza,
fkokosinski,
katsuster,
kgugala,
masz-nordic,
mgielda,
nashif,
npitre,
tgorochowik and
ycsin
fsammoura1980
force-pushed
the
improve_perm_test
branch
3 times, most recently
from
6848683 to
a54cdb7
Compare
jimmyzhe
reviewed
Dec 9, 2025
fsammoura1980
force-pushed
the
improve_perm_test
branch
from
a54cdb7 to
1574146
Compare
jimmyzhe
reviewed
Dec 10, 2025
Contributor
jimmyzhe
left a comment
jimmyzhe
left a comment
There was a problem hiding this comment.
test_successful_permission_change: Locates the index of the target test region (dt_regions[1]) by matching its base address and size. The test now also inverts the R/W bits of the current permissions to ensure a change is applied and verified.
Seems that test_successful_permission_change uses test region dt_regions[0] and inverts the X bit. Could you update the commit message and the comment?
Other than that, these changes LGTM.
The existing PMP permission tests relied on hardcoded region indices
(e.g., index 0 or 2). This makes the tests fragile and dependent
on the exact memory attribute region setup.
This change refactors the tests to dynamically determine region counts
and indices based on the output of `mem_attr_get_regions()`:
- `test_pmp_change_perm_invalid_permission`: Uses the last valid
region index to test invalid permission flags.
- `test_pmp_change_perm_invalid_region_index`: Uses the total number
of regions as the out-of-bounds index.
- `test_successful_permission_change`: Locates the index of the
target test region (`dt_regions[0]`) by matching its base address
and size. The test now also inverts the X bit of the current
permissions to ensure a change is applied and verified.
These changes make the tests more robust and less dependent on a
specific static configuration.
Signed-off-by: Firas Sammoura <[email protected]>
fsammoura1980
force-pushed
the
improve_perm_test
branch
from
1574146 to
91ebdde
Compare
Contributor
Author
Done |
jimmyzhe
approved these changes
Dec 10, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing PMP permission tests relied on hardcoded region indices (e.g., index 0 or 2). This makes the tests fragile and dependent on the exact memory attribute region setup.
This change refactors the tests to dynamically determine region counts and indices based on the output of
mem_attr_get_regions():test_pmp_change_perm_invalid_permission: Uses the last valid region index to test invalid permission flags.test_pmp_change_perm_invalid_region_index: Uses the total number of regions as the out-of-bounds index.test_successful_permission_change: Locates the index of the target test region (dt_regions[0]) by matching its base address and size. The test now also inverts the X bit of the current permissions to ensure a change is applied and verified.These changes make the tests more robust and less dependent on a specific static configuration.