Add led-strip Espressif RMT driver#102053
Add led-strip Espressif RMT driver#102053joelguittet wants to merge 10 commits intozephyrproject-rtos:mainfrom
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hal_espressif
DNM (manifest)
zephyrbot
added
area: Samples
zephyrbot
requested review from
JarmouniA,
LucasTambor,
VynDragon,
andyross,
ceolin,
edersondisouza,
katsuster,
marekmatej,
mgielda,
npitre,
raffarost,
sylvioalves,
thedjnK,
uLipe and
wmrsouza
|
|
||
| #ifndef ZEPHYR_DRIVERS_MISC_ESPRESSIF_RMT_RMT_PRIVATE_H_ | ||
| #define ZEPHYR_DRIVERS_MISC_ESPRESSIF_RMT_RMT_PRIVATE_H_ | ||
|
|
There was a problem hiding this comment.
rmt_private.h is part of the driver in HAL, I suggest to keep this in there and not replicate. This aligns with other Espressif driver and allows proper hal sync/update.
There was a problem hiding this comment.
I didn't find rmt_private.h in the HAL. And I didn't find the definitions made here in the HAL at all.
So I'm not sure to understand your comment...
| #include <zephyr/drivers/misc/espressif_rmt/rmt.h> | ||
| #include <zephyr/drivers/misc/espressif_rmt/rmt_rx.h> | ||
|
|
||
| #ifdef CONFIG_SOC_SERIES_ESP32 |
There was a problem hiding this comment.
All this sigmap.h includes sounds odd. Why can't we use pinctrl?
There was a problem hiding this comment.
This is to use ESP_RMT_SIG_IN0 which is just below. It permit to find a channel ID from the pin. It depends of the SOC. The same exist for rmt_tx.c
|
@joelguittet great! I only reviewed parts of it. I'll do a next round to evaluate logic and workflow. |
joelguittet
force-pushed
the
feature/led-strip-espressif-rmt-driver
branch
3 times, most recently
from
d753223 to
8fd3714
Compare
Thanks a lot @sylvioalves !! |
joelguittet
force-pushed
the
feature/led-strip-espressif-rmt-driver
branch
3 times, most recently
from
6b9e434 to
6f3a7b7
Compare
joelguittet
force-pushed
the
feature/led-strip-espressif-rmt-driver
branch
from
6f3a7b7 to
d9b33e8
Compare
The Espressif RMT driver is created from the ESP-IDF version. Signed-off-by: Joel Guittet <joelguittet@gmail.com>
The RMT peripheral is added to the existing relevant devices. A DTS bindings is created to support this peripheral. Signed-off-by: Joel Guittet <joelguittet@gmail.com>
Adding RMT pinctrl for all relevant ESP32 devices. Signed-off-by: Joel Guittet <joelguittet@gmail.com>
Indicate rmt support for all relevant Espressif boards. Signed-off-by: Joel Guittet <joelguittet@gmail.com>
Add definition for default rmt pinctrl on all relevant boards. GPIO12 and GPIO13 are used by default. Signed-off-by: Joel Guittet <joelguittet@gmail.com>
Adding this application to test espressif_rmt driver using bytes encoder. Signed-off-by: Joel Guittet <joelguittet@gmail.com>
Adding this application to test espressif_rmt driver using simple encoder. Signed-off-by: Joel Guittet <joelguittet@gmail.com>
Update hal to integrate RMT support. Signed-off-by: Joel Guittet <joelguittet@gmail.com>
Support for WS2812 led-strip using Espressif RMT driver. Signed-off-by: Joel Guittet <joelguittet@gmail.com>
This sample is updated to illustrate the usage of WS2812 led-strip Espressif RMT driver. Signed-off-by: Joel Guittet <joelguittet@gmail.com>
joelguittet
force-pushed
the
feature/led-strip-espressif-rmt-driver
branch
from
d9b33e8 to
364fa8a
Compare
|
4 participants
A new led-strip driver for WS2812B, based on Espressif RMT.
This pull request depends of #101448, which need to be merged before the review to be done here.