drivers: wifi: esp-hosted: Add support for the latest firmware. #103154
Conversation
zephyrbot
requested review from
Kludentwo,
MaochenWang1,
jukkar,
krish2718 and
rlubos
iabdalkader
force-pushed
the
esp_hosted_updated
branch
2 times, most recently
from
8ea205c to
693bdfb
Compare
| config WIFI_ESP_HOSTED_LEGACY | ||
| bool "Support legacy (<= v0.0.5) firmware" |
There was a problem hiding this comment.
this should in my option come from the devicetree
There was a problem hiding this comment.
Note it's not just a runtime option, the option changes which protocol file gets used.
There was a problem hiding this comment.
And in zephyr the devicetree is also constant, unlike to linux.
you could for example use
https://docs.zephyrproject.org/latest/build/kconfig/preprocessor-functions.html
$(dt_compat_all_has_prop,<compatible string>,<prop>[,<value>])
$(dt_compat_any_has_prop,<compatible string>,<prop>[,<value>])
to access a value from the dt.
There was a problem hiding this comment.
But can I check in CMakeLists.txt? That's where the protocol file is switched. I guess it's possible, but other than that, any good reason for that? I mean the config option is working perfectly fine, and it's been tested with both old/new firmware.
There was a problem hiding this comment.
But can I check in CMakeLists.txt?
yes
The point is, that the devicetree should contain all necessary information about the hardware. The right way would be to have two different compatibles, as both versions are not compatible with each other.
btw you can still use a Kconfig as a intermediate, that is set by the dt.
There was a problem hiding this comment.
see https://docs.zephyrproject.org/latest/build/dts/dt-vs-kconfig.html
The software version of esp-hosted on the remote esp32 would be considered a hardware property.
There was a problem hiding this comment.
Okay, let me give it a try.
There was a problem hiding this comment.
The software version of esp-hosted on the remote esp32 would be considered a hardware property.
I'm honestly not sure, I think it's a gray area, but I don't mind changing it.
There was a problem hiding this comment.
Updated. I think this is what you meant.
iabdalkader
force-pushed
the
esp_hosted_updated
branch
2 times, most recently
from
8732c7e to
8f68d01
Compare
zephyrbot
added
area: Devicetree Binding
Rename legacy esp-hosted protobuf protocol file, and add the latest protocol. Signed-off-by: Ibrahim Abdalkader <[email protected]>
Add support for esp-hosted v1.0.0.0.0 firmware. Signed-off-by: Ibrahim Abdalkader <[email protected]>
Use legacy esp-hosted firmware protocol. Signed-off-by: Ibrahim Abdalkader <[email protected]>
iabdalkader
force-pushed
the
esp_hosted_updated
branch
from
8f68d01 to
7d258d0
Compare
|
5 participants
The latest stable ESP-hosted firmware (v1.0.0.0.0) is no longer backward compatible with Zephyr's host driver. The main breaking change is the
ConnectAPresponse changing from a synchronous response to an asynchronous event. This is a good change and it's in line with other requests, but it breaks backward compatibility.This PR adds support for the latest firmware while maintaining support for the legacy firmware (v0.0.5) shipped with some boards, via a config option. Moving forward, if ESP ever releases an update, the host driver in Zephyr should by default support the latest firmware.
Note: The latest firmware also introduces new features, such as set/get country code, band argument in requests and responses, uid for frames and some additional events. This PR does not attempt to support every new feature, but just the base functionality.