posix: fix sem_destroy EBUSY return condition #103156
Open
+38
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EBUSY return condition was incorrect and e.g. sem_destroy was in some cases reporting this error even if no thread was blocked by this semaphore. This commit fixes that by checking the waitqueue instead of the semaphore count. Signed-off-by: Jakub Michalski <[email protected]>
This commit modifies this test to properly check EBUSY condition Signed-off-by: Jakub Michalski <[email protected]>
|
zephyrbot
added
area: POSIX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
EBUSYreturn condition ofsem_destroyis based on semaphore count, resulting insem_destroyin some cases reporting this error even if no thread is blocked by it. This PR fixes that by checking semaphore's wait queue instead of its count. The test was also modified to assert the correct behavior.