Port tests upstream nrf7120#103570
Port tests upstream nrf7120#103570rob-robinson-14 wants to merge 37 commits intozephyrproject-rtos:mainfrom
Conversation
rob-robinson-14
force-pushed
the
port-tests-upstream-nrf7120
branch
5 times, most recently
from
227c857 to
4ea3b6f
Compare
zephyrbot
requested review from
57300,
JarmouniA,
anangl,
bjarki-andreasen,
edersondisouza,
henrikbrixandersen,
jaz1-nordic,
katsuster,
kl-cruz,
lgirdwood,
lstnl,
magp-nordic,
masz-nordic,
nika-nordic and
nordic-krch
henrikbrixandersen
left a comment
henrikbrixandersen
left a comment
There was a problem hiding this comment.
Please split this PR into separate PRs for each area affected. See https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#contributor-expectations for further details.
rob-robinson-14
force-pushed
the
port-tests-upstream-nrf7120
branch
from
4ea3b6f to
3915680
Compare
zephyrbot
requested review from
carlescufi,
ceolin,
d3zd3z,
dcpleung and
de-nordic
After porting nRF7120 to Zephyr, all tests that were supported in sdk-nrf must now be supported in Zephyr instead. Signed-off-by: Robert Robinson <[email protected]>
After porting nRF7120 to Zephyr, all tests that were supported in sdk-nrf must now be supported in Zephyr instead. Signed-off-by: Robert Robinson <[email protected]>
After porting nRF7120 to Zephyr, all tests that were supported in sdk-nrf must now be supported in Zephyr instead. Signed-off-by: Robert Robinson <[email protected]>
After porting nRF7120 to Zephyr, all tests that were supported in sdk-nrf must now be supported in Zephyr instead. Signed-off-by: Robert Robinson <[email protected]>
After porting nRF7120 to Zephyr, all tests that were supported in sdk-nrf must now be supported in Zephyr instead. Signed-off-by: Robert Robinson <[email protected]>
After porting nRF7120 to Zephyr, all tests that were supported in sdk-nrf must now be supported in Zephyr instead. Signed-off-by: Robert Robinson <[email protected]>
After porting nRF7120 to Zephyr, all tests that were supported in sdk-nrf must now be supported in Zephyr instead. Signed-off-by: Robert Robinson <[email protected]>
After porting nRF7120 to Zephyr, all tests that were supported in sdk-nrf must now be supported in Zephyr instead. Signed-off-by: Robert Robinson <[email protected]>
rob-robinson-14
force-pushed
the
port-tests-upstream-nrf7120
branch
from
d1ec37e to
69b31ad
Compare
|
@henrikbrixandersen - is it okay to break down into separate commits as is current state? Or the expectation is to raise the 30+ PRs? Thanks for posting contributor expectations - from what I see, so long as each commit in the PR builds cleanly then my approach is okay - but welcome your input here. |
After porting nRF7120 to Zephyr, all tests that were supported in sdk-nrf must now be supported in Zephyr instead. Signed-off-by: Robert Robinson <[email protected]>
After porting nRF7120 to Zephyr, all tests that were supported in sdk-nrf must now be supported in Zephyr instead. Signed-off-by: Robert Robinson <[email protected]>
After porting nRF7120 to Zephyr, all tests that were supported in sdk-nrf must now be supported in Zephyr instead. Signed-off-by: Robert Robinson <[email protected]>
After porting nRF7120 to Zephyr, all tests that were supported in sdk-nrf must now be supported in Zephyr instead. Signed-off-by: Robert Robinson <[email protected]>
After porting nRF7120 to Zephyr, all tests that were supported in sdk-nrf must now be supported in Zephyr instead. Signed-off-by: Robert Robinson <[email protected]>
After porting nRF7120 to Zephyr, all tests that were supported in sdk-nrf must now be supported in Zephyr instead. Signed-off-by: Robert Robinson <[email protected]>
After porting nRF7120 to Zephyr, all tests that were supported in sdk-nrf must now be supported in Zephyr instead. Signed-off-by: Robert Robinson <[email protected]>
After porting nRF7120 to Zephyr, all tests that were supported in sdk-nrf must now be supported in Zephyr instead. Signed-off-by: Robert Robinson <[email protected]>
rob-robinson-14
force-pushed
the
port-tests-upstream-nrf7120
branch
from
69b31ad to
4aa3702
Compare
No, it's also to keep the number of reviewers reasonable, just look at how many are in the list to know it's a bad idea.
I think one for samples, and one for non-essential tests is a good compromise here.
The opposite, reviewers will see a PR with 37 commits, or changing 106 files, and won't even bother looking at it. The same for assignees, I know I won't sign off on a PR with that many things.
The rule of thumb is to minimize the number of areas (in the sense of MAINTAINERS file) being changed to the minimum necessary for the PR to work/be tested. |
|
|
@JarmouniA - okay makes sense. Closing this and replaced by: |
8 participants
Add nRF7120 support for tests and samples in upstream zephyr and resolves any bugs uncovered as part of the process.