soc: nuvoton m48x: use numaker reset driver for uart #103704
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: UART
zephyrbot
requested review from
ChiHuaL,
JarmouniA,
MulinChao,
TomChang19,
alvsun,
ccli8,
cyliangtw,
dcpleung,
decsny,
fabiobaltieri,
keith-zephyr,
maxdog988 and
ssekar15
kloenk
force-pushed
the
nuvoton-m48x-reset-uart
branch
from
7ffe0db to
be0afde
Compare
Author
Changes in V2
|
Member
fabiobaltieri
left a comment
fabiobaltieri
left a comment
There was a problem hiding this comment.
looks good, CI is catching a couple things, it'll run automatically once this is in though
Author
|
The long line comment lint is also from the BSP. but guess we also want to alter the file there? |
Use the numaker reset driver for the reset in the numicro uart driver. Signed-off-by: Fiona Behrens <[email protected]>
kloenk
force-pushed
the
nuvoton-m48x-reset-uart
branch
from
be0afde to
b248ba3
Compare
Author
|
Not sure if the doxygen lint is required in this case? as this are just board constants to be used in devicetrees and self documenting for that usecase/documented in the nuvoton TRM? Changes in v3
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the numaker reset driver for the reset in the numicro uart driver.