drivers: sensors: AMS Air quality Sensor Implementations #10431

alexanderwachter · 2018-10-08T15:08:24Z

Implementation of AMS iAQ-core and ENS210 Sensors and samples

alexanderwachter · 2018-10-08T15:12:51Z

Code is tested on a PCA10059 board with a custom board for sensor hardware attached.

drivers/sensor/ams_iAQcore/Kconfig

codecov-io · 2018-10-08T15:53:57Z

Codecov Report

Merging #10431 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10431      +/-   ##
==========================================
- Coverage   52.02%   51.98%   -0.04%     
==========================================
  Files         307      307              
  Lines       45484    45484              
  Branches    10535    10535              
==========================================
- Hits        23662    23646      -16     
- Misses      17030    17042      +12     
- Partials     4792     4796       +4

Impacted Files	Coverage Δ
subsys/testsuite/ztest/include/ztest_assert.h	`38.88% <0%> (-38.89%)`	⬇️
subsys/testsuite/ztest/src/ztest.c	`65.28% <0%> (-7.44%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ac2461...5b0c29b. Read the comment docs.

zephyrbot · 2019-03-01T10:36:05Z

Found the following issues, please fix and resubmit:

License issues

In most cases you do not need to do anything here, especially if the files
reported below are going into ext/ and if license was approved for inclusion
into ext/ already. Fix any missing license/copyright issues. The license
exception if a JFYI for the maintainers and can be overriden when merging the
pull request.

drivers/sensor/ams_iAQcore/CMakeLists.txt missing copyright.
drivers/sensor/ens210/CMakeLists.txt missing copyright.
samples/sensor/ams_iAQcore/CMakeLists.txt missing copyright.
samples/sensor/ens210/CMakeLists.txt missing copyright.

CODEOWNERS

alexanderwachter · 2019-03-02T16:43:14Z

It seems I need to whitelist or blacklist some platforms because not every board has an i2c0.
@MaureenHelm is it possible to whitelist only boards with i2c0 or is it possible to switch dts overlays depending on the availability of i2cx?

alexanderwachter · 2019-03-02T17:06:44Z

Updated to new logger.

MaureenHelm · 2019-03-04T20:13:12Z

It seems I need to whitelist or blacklist some platforms because not every board has an i2c0.
@MaureenHelm is it possible to whitelist only boards with i2c0 or is it possible to switch dts overlays depending on the availability of i2cx?

Can you make it depend on arduino_i2c?

drivers/sensor/ams_iAQcore/iAQcore.c

MaureenHelm · 2019-03-05T18:48:31Z

samples/sensor/ams_iAQcore/CMakeLists.txt

Add a license/copyright header and update to VERSION 3.13.1

license to the CMake file?

samples/sensor/ams_iAQcore/src/main.c

drivers/sensor/ens210/ens210.c

MaureenHelm · 2019-03-05T18:59:09Z

samples/sensor/ens210/CMakeLists.txt

Update version and add license/copyright header

samples/sensor/ens210/src/main.c

tests/drivers/build_all/dts_fixup.h

dbkinder

Docs look good, with a couple of small tweaks...

samples/sensor/ams_iAQcore/README.rst

samples/sensor/ens210/README.rst

samples/sensor/ams_iAQcore/README.rst

drivers/sensor/ens210/ens210.c

samples/sensor/ens210/README.rst

Implementation of AMS (Austria Micro Systems) Indoor Air Quality Sensor Signed-off-by: Alexander Wachter <[email protected]>

Sample code for AMS (Austria Micro Systems) Indoor Air Quality Sensor reading VOC and equivalent CO2 values. Signed-off-by: Alexander Wachter <[email protected]>

Implementation of AMS (Austria Micro Systems) ENS210 temperature and relative humidity sensor. Signed-off-by: Alexander Wachter <[email protected]>

Sample code for AMS (Austria Micro Systems) ENS210 temperature and relative humidity sensor. Signed-off-by: Alexander Wachter <[email protected]>

This commit adds IAQcore and ENS210 from AMS to the build tests. Signed-off-by: Alexander Wachter <[email protected]>

@alexanderwachter

Add @alexanderwachter as codeowner for AMS iAQcore and ENS210 Signed-off-by: Alexander Wachter <[email protected]>

alexanderwachter · 2019-04-19T12:57:24Z

Added license header to cmake files.

stale

MaureenHelm

Thanksk @alexanderwachter for your patience

alexanderwachter requested a review from MaureenHelm as a code owner October 8, 2018 15:08

alexanderwachter added the area: Sensors Sensors label Oct 8, 2018

tbursztyka reviewed Oct 8, 2018

View reviewed changes

drivers/sensor/ams_iAQcore/Kconfig Outdated Show resolved Hide resolved

alexanderwachter force-pushed the iAQcore branch 2 times, most recently from b50d1f3 to 6b1c418 Compare October 8, 2018 15:24

alexanderwachter force-pushed the iAQcore branch from 6b1c418 to 45130db Compare March 1, 2019 10:30

alexanderwachter force-pushed the iAQcore branch 4 times, most recently from b345565 to bdc9726 Compare March 2, 2019 15:35

nashif reviewed Mar 2, 2019

View reviewed changes

CODEOWNERS Outdated Show resolved Hide resolved

alexanderwachter force-pushed the iAQcore branch from bdc9726 to 16fdb6c Compare March 2, 2019 15:56

alexanderwachter force-pushed the iAQcore branch from 16fdb6c to 8106690 Compare March 2, 2019 17:06

alexanderwachter requested a review from nashif March 2, 2019 17:12

alexanderwachter force-pushed the iAQcore branch from 8106690 to e851a27 Compare March 2, 2019 20:58

alexanderwachter force-pushed the iAQcore branch from e851a27 to 7111bbd Compare March 4, 2019 20:28

alexanderwachter added this to the v1.14.0 milestone Mar 4, 2019

alexanderwachter requested a review from avisconti March 4, 2019 20:46

alexanderwachter force-pushed the iAQcore branch from 7111bbd to adc0ca6 Compare March 4, 2019 21:11

galak added the TSC Topics that need TSC discussion label Mar 5, 2019

MaureenHelm requested changes Mar 5, 2019

View reviewed changes

alexanderwachter force-pushed the iAQcore branch from adc0ca6 to 7e0a27f Compare March 6, 2019 16:01

alexanderwachter requested a review from dbkinder as a code owner March 6, 2019 16:01

alexanderwachter force-pushed the iAQcore branch from 7e0a27f to 21d9561 Compare March 6, 2019 16:09

alexanderwachter force-pushed the iAQcore branch 2 times, most recently from 909f999 to b1e1042 Compare March 6, 2019 16:50

alexanderwachter requested a review from MaureenHelm March 6, 2019 17:56

dbkinder previously requested changes Mar 6, 2019

View reviewed changes

samples/sensor/ams_iAQcore/README.rst Outdated Show resolved Hide resolved

samples/sensor/ens210/README.rst Outdated Show resolved Hide resolved

alexanderwachter force-pushed the iAQcore branch from b1e1042 to 803a6e7 Compare March 6, 2019 20:05

MaureenHelm requested changes Mar 6, 2019

View reviewed changes

samples/sensor/ams_iAQcore/README.rst Outdated Show resolved Hide resolved

drivers/sensor/ens210/ens210.c Outdated Show resolved Hide resolved

samples/sensor/ens210/README.rst Outdated Show resolved Hide resolved

alexanderwachter force-pushed the iAQcore branch 3 times, most recently from 0fb3105 to 5b0c29b Compare March 10, 2019 11:02

MaureenHelm approved these changes Mar 11, 2019

View reviewed changes

alexanderwachter modified the milestones: v1.14.0, v1.15.0 Mar 15, 2019

alexanderwachter removed the TSC Topics that need TSC discussion label Mar 15, 2019

Alexander Wachter added 3 commits April 19, 2019 14:49

drivers: sensor: ams_iAQcore: Implemented ASM Indoor Air Quality Sensor

c6d5c97

Implementation of AMS (Austria Micro Systems) Indoor Air Quality Sensor Signed-off-by: Alexander Wachter <[email protected]>

samples: sensor: ams_iAQcore: Implement sample for AMS iAQ-core

8610b7e

Sample code for AMS (Austria Micro Systems) Indoor Air Quality Sensor reading VOC and equivalent CO2 values. Signed-off-by: Alexander Wachter <[email protected]>

drivers: sensor: ens210: Implement AMS ens210 Sensor

27a163e

Implementation of AMS (Austria Micro Systems) ENS210 temperature and relative humidity sensor. Signed-off-by: Alexander Wachter <[email protected]>

alexanderwachter force-pushed the iAQcore branch from 5b0c29b to 1ab1c84 Compare April 19, 2019 12:54

alexanderwachter requested a review from galak as a code owner April 19, 2019 12:54

Alexander Wachter added 3 commits April 19, 2019 14:54

samples: sensor: ens210: Implement sample for ens210

dbadcc3

Sample code for AMS (Austria Micro Systems) ENS210 temperature and relative humidity sensor. Signed-off-by: Alexander Wachter <[email protected]>

tests: drivers: build_all: Add AMS IAQcore and ENS210 to build all

5c185c3

This commit adds IAQcore and ENS210 from AMS to the build tests. Signed-off-by: Alexander Wachter <[email protected]>

CODEOWNERS: Add codeowner for ams iAQcore and ENS210

1ab1c84

Add @alexanderwachter as codeowner for AMS iAQcore and ENS210 Signed-off-by: Alexander Wachter <[email protected]>

carlescufi approved these changes Apr 19, 2019

View reviewed changes

MaureenHelm approved these changes Apr 19, 2019

View reviewed changes

MaureenHelm merged commit 9e8ad2d into zephyrproject-rtos:master Apr 19, 2019

alexanderwachter deleted the iAQcore branch January 30, 2021 10:01

drivers: sensors: AMS Air quality Sensor Implementations #10431

drivers: sensors: AMS Air quality Sensor Implementations #10431

Uh oh!

Conversation

alexanderwachter commented Oct 8, 2018

Uh oh!

alexanderwachter commented Oct 8, 2018

Uh oh!

Uh oh!

codecov-io commented Oct 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zephyrbot commented Mar 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License issues

Uh oh!

Uh oh!

alexanderwachter commented Mar 2, 2019

Uh oh!

alexanderwachter commented Mar 2, 2019

Uh oh!

MaureenHelm commented Mar 4, 2019

Uh oh!

Uh oh!

Uh oh!

MaureenHelm Mar 5, 2019

Choose a reason for hiding this comment

Uh oh!

alexanderwachter Mar 6, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MaureenHelm Mar 5, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dbkinder left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexanderwachter commented Apr 19, 2019

Uh oh!

MaureenHelm left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

codecov-io commented Oct 8, 2018 •

edited

Loading

zephyrbot commented Mar 1, 2019 •

edited

Loading

dbkinder left a comment •

edited

Loading