SAMPLES: BL : Bap_broadcast_source & sink: Added BIS_Number to log#106771
SAMPLES: BL : Bap_broadcast_source & sink: Added BIS_Number to log#106771fjepse22 wants to merge 5 commits intozephyrproject-rtos:mainfrom
Conversation
BIS_Number is now written when the program logs that the stream have sent packets
Added the BIS_NUMBER to the ISO_stream that is recieved.
|
Hello @fjepse22, and thank you very much for your first pull request to the Zephyr project! |
Fixed wrong formatting of the code. Made the code comply with the writing guidelines as instructed by the checks from github. Signed-off-by: Frederik Bredtoft Boel Jespsen fjepse22@student.aau.dk
made changes to make the changes comply with the writing guidelines. Signed-off-by: Frederik Bredtoft Boel Jepsen fjepse22@student.aau.dk
added * for each line in added comments
fjepse22
left a comment
There was a problem hiding this comment.
I added changes to the code I made so it hopefully complies with the written code guidelines now.
|
❌ The last analysis has failed. |
SAMPLES: BL : Bap_broadcast_source & sink: Added BIS_Number to log
When people are new to Zephyr and run babblesim to learn how packets are received. Currently the different streams are identified by a pointer address to local memory for the device and not unique identification of the stream itself. I hope adding the BIS_Number to the log would help.
Practical changes
For the BAP_Broadcast_Sink
Changed log_stream_rx() so BIS_Number for the ISO stream is extracted and written to the out log.
For BAP_Broadcast_Source
send_data() now writes the BIS_Number for the stream
Note the function bt_iso_chan_get_info() is called every time when there is written to log for both samples, so there is function call overhead. A sollution whould be to save the information from bt_iso_chan_get_info() for each stream.
Signed-off-by: Frederik Bredtoft Boel Jepsen fjepse22@student.aau.dk