Skip to content

SAMPLES: BL : Bap_broadcast_source & sink: Added BIS_Number to log#106771

Open
fjepse22 wants to merge 5 commits intozephyrproject-rtos:mainfrom
fjepse22:main
Open

SAMPLES: BL : Bap_broadcast_source & sink: Added BIS_Number to log#106771
fjepse22 wants to merge 5 commits intozephyrproject-rtos:mainfrom
fjepse22:main

Conversation

@fjepse22
Copy link
Copy Markdown

@fjepse22 fjepse22 commented Apr 2, 2026

SAMPLES: BL : Bap_broadcast_source & sink: Added BIS_Number to log

When people are new to Zephyr and run babblesim to learn how packets are received. Currently the different streams are identified by a pointer address to local memory for the device and not unique identification of the stream itself. I hope adding the BIS_Number to the log would help.

Practical changes

For the BAP_Broadcast_Sink
Changed log_stream_rx() so BIS_Number for the ISO stream is extracted and written to the out log.

For BAP_Broadcast_Source

send_data() now writes the BIS_Number for the stream

Note the function bt_iso_chan_get_info() is called every time when there is written to log for both samples, so there is function call overhead. A sollution whould be to save the information from bt_iso_chan_get_info() for each stream.

Signed-off-by: Frederik Bredtoft Boel Jepsen fjepse22@student.aau.dk

fjepse22 added 2 commits April 2, 2026 17:00
BIS_Number is now written when the program logs that the stream have sent packets
Added the BIS_NUMBER to the ISO_stream that is recieved.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Hello @fjepse22, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

fjepse22 added 3 commits April 2, 2026 18:15
Fixed wrong formatting of the code.

Made the code comply with the writing guidelines as instructed by the checks from github.


Signed-off-by: Frederik Bredtoft Boel Jespsen fjepse22@student.aau.dk
made changes to make the changes comply with the writing guidelines.

Signed-off-by: Frederik Bredtoft Boel Jepsen fjepse22@student.aau.dk
added * for each line in added comments
Copy link
Copy Markdown
Author

@fjepse22 fjepse22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added changes to the code I made so it hopefully complies with the written code guidelines now.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 2, 2026

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

3 participants