Skip to content

Conversation

@cybertale
Copy link
Contributor

The old defines make the Shippable tests fail. Convert the fixing
ups for fxos8700 to use new defines introduced in #12491.

Signed-off-by: Song Qiang [email protected]

The old defines make the Shippable tests fail. Convert the fixing
ups for fxos8700 to use new defines introduced in zephyrproject-rtos#12491.

Signed-off-by: Song Qiang <[email protected]>
@cybertale
Copy link
Contributor Author

@galak

@codecov-io
Copy link

Codecov Report

Merging #14242 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14242      +/-   ##
==========================================
- Coverage   52.02%   51.98%   -0.04%     
==========================================
  Files         307      307              
  Lines       45484    45484              
  Branches    10535    10535              
==========================================
- Hits        23662    23646      -16     
- Misses      17030    17042      +12     
- Partials     4792     4796       +4
Impacted Files Coverage Δ
subsys/testsuite/ztest/include/ztest_assert.h 38.88% <0%> (-38.89%) ⬇️
subsys/testsuite/ztest/src/ztest.c 65.28% <0%> (-7.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ac2461...6a95a69. Read the comment docs.

@galak
Copy link
Contributor

galak commented Mar 10, 2019

The old defines make the Shippable tests fail. Convert the fixing
ups for fxos8700 to use new defines introduced in #12491.

which CI test is failing?

@cybertale
Copy link
Contributor Author

@galak tests/drivers/build_all

@galak
Copy link
Contributor

galak commented Mar 10, 2019

@galak tests/drivers/build_all

how are you seeing the failure, when I build via sanitycheck I don't see any issue.

@cybertale
Copy link
Contributor Author

cybertale commented Mar 11, 2019 via email

@galak galak merged commit 5c0f6a3 into zephyrproject-rtos:master Mar 15, 2019
@cybertale cybertale deleted the tests-build_all-fxos branch March 19, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants