kernel/spinlock: More validation #14286
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catching the error in a function is nice, but one really wants to know where it happened, and where the recursive lock was taken (or where the unowned release was actually grabbed). Add a layer of macro indirection to catch this info and log it with the assertion. Signed-off-by: Andy Ross <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #14286 +/- ##
==========================================
+ Coverage 51.97% 51.98% +<.01%
==========================================
Files 308 308
Lines 45512 45518 +6
Branches 10546 10547 +1
==========================================
+ Hits 23657 23662 +5
Misses 17055 17055
- Partials 4800 4801 +1
Continue to review full report at Codecov.
|
|
Folded into #13800 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Another one not for 1.14. Pushed for others to test with. Adds yet more detail to spinlock assertions.]
Catching the error in a function is nice, but one really wants to know
where it happened, and where the recursive lock was taken (or where
the unowned release was actually grabbed). Add a layer of macro
indirection to catch this info and log it with the assertion.
Signed-off-by: Andy Ross [email protected]