kconfig: drivers: bluetooth: clean up Kconfig dependencies #14314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 12, 2019 18:15
Remove use of select to "force" enabling other configs in subsys/fs and subsys/net/l2. The forcing will cause infinite kconfig recursion. Signed-off-by: Thomas Stenersen <[email protected]>
This moves the vendor-specific HCI command/event configuration definitions out of bluetooth/common into bluetooth. This allows the controller itself to indicate its support for vendor-specific commands/events. Signed-off-by: Thomas Stenersen <[email protected]>
Redefining the config will not let another (out-of-source) driver be chosen instead of the default. The driver is practically forced by the soc settings. This commit moves default settings from soc/arm/nordic_nrf into the drivers themselves. Signed-off-by: Thomas Stenersen <[email protected]>
Add choice variables for CLOCK_CONTROL_NRF_SOURCE and CLOCK_CONTROL_NRF_ACCURACY such that the choices may be augmented out-of-tree. Signed-off-by: Thomas Stenersen <[email protected]>
thomasstenersen
requested review from
Vudentz,
aescolar,
carlescufi,
cvinayak,
ioannisg,
jhedberg,
jukkar,
nashif,
pfalcon,
sjanc,
tbursztyka and
thoh-ot
as code owners
carlescufi
requested changes
Mar 12, 2019
subsys/bluetooth/host/Kconfig
Outdated
There was a problem hiding this comment.
Why did you change the default here?
There was a problem hiding this comment.
To accommodate the worst case stack requirement if an out-of-tree controller is used. I'll add a comment in the code here and in the commit with the reasoning.
aescolar
approved these changes
Mar 12, 2019
By specifying the controller directly when selecting the default BT_HCI_TX_STACK_SIZE, an external controller may rely on the final default value when none of the in-tree controllers are used. The value is increased to 1024 to accomodate the current worst-case stack size. Signed-off-by: Thomas Stenersen <[email protected]>
thomasstenersen
force-pushed
the
kconfig_cleanup
branch
from
a150021 to
ab3a94e
Compare
carlescufi
approved these changes
Mar 12, 2019
cvinayak
approved these changes
Mar 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #14314 +/- ##
==========================================
+ Coverage 51.97% 52.12% +0.14%
==========================================
Files 308 308
Lines 45512 45527 +15
Branches 10546 10552 +6
==========================================
+ Hits 23656 23732 +76
+ Misses 17055 16990 -65
- Partials 4801 4805 +4
Continue to review full report at Codecov.
|
|
Merging since this is the non-contentious portion of #13631 which was already reviewed several days ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes from #13631 without the out-of-tree driver support. It cleans up Kconfig dependencies in Nordic drivers and in the Bluetooth subsystem.