Skip to content

Conversation

@jhqian
Copy link
Contributor

@jhqian jhqian commented Mar 20, 2019

Add board/device support for RT1015 based on SDK 2.5.0 release

@zephyrbot
Copy link

zephyrbot commented Mar 20, 2019

All checks are passing now.

Review history of this comment for details about previous failed status.
Note that some checks might have not completed yet.

@codecov-io
Copy link

codecov-io commented Mar 20, 2019

Codecov Report

Merging #14694 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14694   +/-   ##
=======================================
  Coverage   52.51%   52.51%           
=======================================
  Files         309      309           
  Lines       45048    45048           
  Branches    10419    10419           
=======================================
  Hits        23657    23657           
  Misses      16583    16583           
  Partials     4808     4808

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f6ab22...33c3357. Read the comment docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove lines 11-13

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #14000 for an update to this section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll update it according to that. What shall I put for the opensda firmware? It's not available yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with the commit of 641a245.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the references to jlink opensda firmware. You can follow what I did in the rt1060 board document.

@MaureenHelm MaureenHelm added this to the v1.15.0 milestone Mar 20, 2019
Copy link
Contributor

@agansari agansari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor change requests, the rest looks good.
Updating /ext folder with newer SDK was it tested on other boards?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 uarts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this code used? it's not set in device tree.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, it should be UART4 rather than UART2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a bare URL, how about:

Suggested change
Instead, see the https://www.nxp.com/docs/en/application-note/AN12108.pdf for flashing instructions.
Instead, see the `How to Enable Boot from QSPI Flash Application note
<https://www.nxp.com/docs/en/application-note/AN12108.pdf>`_ for flashing instructions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section has been updated according to the PR #14000.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have such a Zephyr document label. What are you trying to reference?

Copy link
Contributor Author

@jhqian jhqian Mar 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's based on the PR #14000, I think this PR will be approved after that one. I'll rebase it after #14000 is merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have such a Zephyr document label? Maybe you mean :ref:`nxp_opensda_pyocd`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No such Zephyr doc label. Maybe you mean :ref:`nxp_opensda_jlink`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No such Zephyr doc label.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No such Zephyr doc label.

Copy link

@MeganHansen MeganHansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The index.rst file looks good from a marketing review standpoint. Please proceed.

@hakehuang
Copy link
Contributor

@jhqian do you config the MPU region for rt1015, as there is no SEMC, so the address from 0x80000000 need to be configured as device type, but in arm cortex-m7 this area is default as normal type.

Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK now, thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be: jumpers J45 and J46

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the references to jlink opensda firmware. You can follow what I did in the rt1060 board document.

@jhqian jhqian requested a review from MaureenHelm April 17, 2019 02:30
jhqian added 4 commits April 17, 2019 15:18
Add mcux 2.5.0 drivers and device header files for mimxrt1015. Update
several drivers that were already imported for other SoCs but also apply
to mimxrt1015.

Origins: NXP MCUxpresso SDK 2.5.0
URL: mcuxpresso.nxp.com
Maintained-by: External

Signed-off-by: Ryan QIAN <[email protected]>
- Add SoC information for RT1015

Signed-off-by: Ryan QIAN <[email protected]>
- Add config for uart 4

Signed-off-by: Ryan QIAN <[email protected]>
Add board support files for mimxrt1015_evk, the development board for
i.mxrt1015 (CM7) SoC.

- Add pinmux, dts, and doc.
- Tested samples: hello_world, philosophers, synchronization,
basic/blinky, basic/button.

Signed-off-by: Ryan QIAN <[email protected]>
@MaureenHelm MaureenHelm merged commit 4097a5b into zephyrproject-rtos:master Apr 18, 2019
@MaureenHelm MaureenHelm deleted the enable_imxrt1015 branch April 18, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants