-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Enable imxrt1015 #14694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable imxrt1015 #14694
Conversation
|
All checks are passing now. Review history of this comment for details about previous failed status. |
Codecov Report
@@ Coverage Diff @@
## master #14694 +/- ##
=======================================
Coverage 52.51% 52.51%
=======================================
Files 309 309
Lines 45048 45048
Branches 10419 10419
=======================================
Hits 23657 23657
Misses 16583 16583
Partials 4808 4808Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove lines 11-13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see #14000 for an update to this section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll update it according to that. What shall I put for the opensda firmware? It's not available yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested with the commit of 641a245.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the references to jlink opensda firmware. You can follow what I did in the rt1060 board document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some minor change requests, the rest looks good.
Updating /ext folder with newer SDK was it tested on other boards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 uarts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
boards/arm/mimxrt1015_evk/pinmux.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this code used? it's not set in device tree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, it should be UART4 rather than UART2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of a bare URL, how about:
| Instead, see the https://www.nxp.com/docs/en/application-note/AN12108.pdf for flashing instructions. | |
| Instead, see the `How to Enable Boot from QSPI Flash Application note | |
| <https://www.nxp.com/docs/en/application-note/AN12108.pdf>`_ for flashing instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section has been updated according to the PR #14000.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have such a Zephyr document label. What are you trying to reference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have such a Zephyr document label? Maybe you mean :ref:`nxp_opensda_pyocd`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No such Zephyr doc label. Maybe you mean :ref:`nxp_opensda_jlink`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No such Zephyr doc label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No such Zephyr doc label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The index.rst file looks good from a marketing review standpoint. Please proceed.
|
@jhqian do you config the MPU region for rt1015, as there is no SEMC, so the address from 0x80000000 need to be configured as device type, but in arm cortex-m7 this area is default as normal type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK now, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be: jumpers J45 and J46
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the references to jlink opensda firmware. You can follow what I did in the rt1060 board document.
Add mcux 2.5.0 drivers and device header files for mimxrt1015. Update several drivers that were already imported for other SoCs but also apply to mimxrt1015. Origins: NXP MCUxpresso SDK 2.5.0 URL: mcuxpresso.nxp.com Maintained-by: External Signed-off-by: Ryan QIAN <[email protected]>
- Add SoC information for RT1015 Signed-off-by: Ryan QIAN <[email protected]>
- Add config for uart 4 Signed-off-by: Ryan QIAN <[email protected]>
Add board support files for mimxrt1015_evk, the development board for i.mxrt1015 (CM7) SoC. - Add pinmux, dts, and doc. - Tested samples: hello_world, philosophers, synchronization, basic/blinky, basic/button. Signed-off-by: Ryan QIAN <[email protected]>
Add board/device support for RT1015 based on SDK 2.5.0 release