tests/drivers/ipm: Enable on (uniprocessor) x86_64 #15191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was having trouble earlier (at least with some toolchains), but whatever was causing that seems to have been fixed. The only remaining issue is that neither the IPM console code nor the test are SMP-safe. There's a bug (zephyrproject-rtos#14639) tracking the need to get these working, but for now the straightforward workaround is just to disable SMP. And even long term, IPM is an oddball interprocessor communication mechanism designed for asymmetric multiprocessing devices like Quark SE and doesn't seem like an obvious fit for a SMP machine. Fixes zephyrproject-rtos#12478 Signed-off-by: Andy Ross <[email protected]>
|
Ran this on both my dev machine and an only-slightly-stale CI docker image and it worked for 30 runs each without failure. Should be OK in the actual CI, but note that the earliest version of this bug was weirdly spurious and from an era before SMP became default, so.. |
dcpleung
approved these changes
Apr 4, 2019
andyross
added
area: Debugging
bug
andrewboie
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Let's just skip the SMP work in #14619 and commit the obvious workaround for now. There's a giant task for 1.15 to make all the tests and subsystems SMP-safe anyway, there's no need to jump through different hoops for IPM of all things.]
This test was having trouble earlier (at least with some toolchains),
but whatever was causing that seems to have been fixed. The only
remaining issue is that neither the IPM console code nor the test are
SMP-safe. There's a bug (#14639) tracking the need to get these
working, but for now the straightforward workaround is just to disable
SMP.
And even long term, IPM is an oddball interprocessor communication
mechanism designed for asymmetric multiprocessing devices like Quark
SE and doesn't seem like an obvious fit for a SMP machine.
Fixes #12478
Signed-off-by: Andy Ross [email protected]