drivers/i2s_ll_stm32.c: (FIX) Avoid warning in LOG_ERR #15857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LL_I2S_ReadReg() function returns uint32_t, while %d requires 'int' as a type. Signed-off-by: Armando Visconti <[email protected]>
avisconti
added
bug
Closed
galak
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LL_I2S_ReadReg() function returns uint32_t, while %d requires 'int' as a type.
This PR fixes following warning:
zephyr/drivers/i2s/i2s_ll_stm32.c: In function 'i2s_stm32_isr':
zephyr/drivers/i2s/i2s_ll_stm32.c:612:28: warning: format '%d' expects argument of type 'int', but argument 3 has type 'uint32_t' {aka 'volatile long unsigned int'} [-Wformat=]
LOG_ERR("%s: err=%d", func, LL_I2S_ReadReg(cfg->i2s, SR));
^~~~~~~~~~~~ ~~~~~~~~~~~~
It has been noted when CONFIG_NEWLIB_LIBC is enabled.
It should fix #15566 (@overheat) and potentially #14111