-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Bluetooth: host: Refactor checks in update_ccc for efficiency #20579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jhedberg
merged 1 commit into
zephyrproject-rtos:master
from
wopu-ot:ccc_update_optimize
Dec 12, 2019
Merged
Bluetooth: host: Refactor checks in update_ccc for efficiency #20579
jhedberg
merged 1 commit into
zephyrproject-rtos:master
from
wopu-ot:ccc_update_optimize
Dec 12, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joerchan
suggested changes
Nov 12, 2019
joerchan
suggested changes
Nov 12, 2019
Vudentz
reviewed
Nov 12, 2019
Check peer address only if active. Signed-off-by: Wolfgang Puffitsch <[email protected]>
0fe4573 to
50e1cee
Compare
Vudentz
approved these changes
Nov 13, 2019
Contributor
Vudentz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jhedberg
approved these changes
Nov 13, 2019
fnde-ot
approved these changes
Nov 14, 2019
Contributor
fnde-ot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too!
joerchan
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host checks whether an update is needed out of loop to look for
peer. This enables skipping looking for the peer if no update is
needed in the first place. No functional change intended.
Signed-off-by: Wolfgang Puffitsch [email protected]