arch_interface: Remove duplicate irq_offload_routine_t typedef. #20619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes duplicate 'irq_offload_routine_t' typedef declaration in sys/arch_interface.h. This typedef is provided by irq_offload.h and, since this header file is included at the top of sys/arch_interface.h, it is guaranteed to be defined for arch_irq_offload definition. While this does not cause a compilation error when compiling with GCC 4.6 and above, GCC 4.5 and below strictly enforce the C99 standard and do not allow redeclaration of the same typedef in the same scope. Signed-off-by: Stephanos Ioannidis <[email protected]>
stephanosio
requested review from
MaureenHelm,
carlescufi,
galak and
nashif
as code owners
Member
Author
|
Similar to the issue #20605. |
stephanosio
added
the
area: Portability
galak
approved these changes
Nov 12, 2019
ioannisg
approved these changes
Nov 12, 2019
Member
ioannisg
left a comment
ioannisg
left a comment
There was a problem hiding this comment.
Fine with me - I think we can still merge this during freeze period - it's cleanup.
andrewboie
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes duplicate 'irq_offload_routine_t' typedef
declaration in sys/arch_interface.h.
This typedef is provided by irq_offload.h and, since this header file
is included at the top of sys/arch_interface.h, it is guaranteed to be
defined for arch_irq_offload definition.
While this does not cause a compilation error when compiling with GCC
4.6 and above, GCC 4.5 and below strictly enforce the C99 standard and
do not allow redeclaration of the same typedef in the same scope.
Signed-off-by: Stephanos Ioannidis [email protected]