Skip to content

Conversation

@ulfalizer
Copy link
Contributor

Remove leading/trailing blank lines in .c, .h, .py, .rst, .yml, and
.yaml files.

Will avoid failures with the new CI test in
zephyrproject-rtos/ci-tools#112, though it only
checks changed files.

Move the 'target-notes' target in boards/xtensa/odroid_go/doc/index.rst
to get rid of the trailing blank line there. It was probably misplaced.

@galak galak added the TSC Topics that need TSC discussion label Nov 18, 2019
@galak
Copy link
Contributor

galak commented Nov 18, 2019

Marking this TSC to see if we want to merge this for the release.

Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc changes LGTM.

@carlescufi
Copy link
Member

As per TSC meeting there is no one actively requesting this PR to be merged during the feature freeze window, so it will be deferred until 2.1 is released.

@MaureenHelm MaureenHelm removed the TSC Topics that need TSC discussion label Nov 20, 2019
@stephanosio stephanosio added this to the v2.2.0 milestone Nov 21, 2019
@dbkinder
Copy link
Contributor

Is it a (new) requirement not to have leading/trailing blank lines in these files? We should document that in our coding/documenting guidelines (and enforce it as we do for trailing white-space on lines).

@ulfalizer
Copy link
Contributor Author

ulfalizer commented Dec 2, 2019

Is it a (new) requirement not to have leading/trailing blank lines in these files? We should document that in our coding/documenting guidelines (and enforce it as we do for trailing white-space on lines).

Think it's usually a typo, so don't know how much it would help to document it.

zephyrproject-rtos/ci-tools#112 will flag it automatically.

Remove leading/trailing blank lines in .c, .h, .py, .rst, .yml, and
.yaml files.

Will avoid failures with the new CI test in
zephyrproject-rtos/ci-tools#112, though it only
checks changed files.

Move the 'target-notes' target in boards/xtensa/odroid_go/doc/index.rst
to get rid of the trailing blank line there. It was probably misplaced.

Signed-off-by: Ulf Magnusson <[email protected]>
@ulfalizer ulfalizer force-pushed the leading-trailing-blanks branch from f839df9 to e5b5bd8 Compare December 10, 2019 17:04
@ulfalizer ulfalizer requested a review from arnopo as a code owner December 10, 2019 17:04
@ulfalizer
Copy link
Contributor Author

Rebased now.

@ioannisg ioannisg merged commit 984bfae into zephyrproject-rtos:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.