-
Notifications
You must be signed in to change notification settings - Fork 8.2k
global: Remove leading/trailing blank lines in files #20758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
global: Remove leading/trailing blank lines in files #20758
Conversation
|
Marking this TSC to see if we want to merge this for the release. |
dbkinder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc changes LGTM.
|
As per TSC meeting there is no one actively requesting this PR to be merged during the feature freeze window, so it will be deferred until 2.1 is released. |
|
Is it a (new) requirement not to have leading/trailing blank lines in these files? We should document that in our coding/documenting guidelines (and enforce it as we do for trailing white-space on lines). |
Think it's usually a typo, so don't know how much it would help to document it. zephyrproject-rtos/ci-tools#112 will flag it automatically. |
Remove leading/trailing blank lines in .c, .h, .py, .rst, .yml, and .yaml files. Will avoid failures with the new CI test in zephyrproject-rtos/ci-tools#112, though it only checks changed files. Move the 'target-notes' target in boards/xtensa/odroid_go/doc/index.rst to get rid of the trailing blank line there. It was probably misplaced. Signed-off-by: Ulf Magnusson <[email protected]>
f839df9 to
e5b5bd8
Compare
|
Rebased now. |
Remove leading/trailing blank lines in .c, .h, .py, .rst, .yml, and
.yaml files.
Will avoid failures with the new CI test in
zephyrproject-rtos/ci-tools#112, though it only
checks changed files.
Move the 'target-notes' target in boards/xtensa/odroid_go/doc/index.rst
to get rid of the trailing blank line there. It was probably misplaced.