Skip to content

DTC warning suppression #20828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 5, 2020
Merged

DTC warning suppression #20828

merged 5 commits into from
Feb 5, 2020

Conversation

@agansari
Copy link
Contributor

@agansari agansari commented Nov 20, 2019

Allows boards to have a extra.cmake that allows for custom cmake commands.
We use the extra.cmake file to set EXTRA_DTC_FLAGS to suppress warnings on LPC SoC that have a single register address for all gpio ports.

Fixes #20748

@zephyrbot
Copy link

zephyrbot commented Nov 20, 2019 •
edited
Loading

All checks are passing now.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

ulfalizer
ulfalizer reviewed Nov 20, 2019
View reviewed changes
Copy link
Contributor

@ulfalizer ulfalizer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if there's some simpler way to fix it on the devicetree side, e.g. by leaving out the unit address, or refactoring in some other way.

@SebastianBoe
Copy link
Contributor

SebastianBoe commented Nov 20, 2019

What's wrong with the board.cmake hook? Is it placed too early / too late ?

@agansari
Copy link
Contributor Author

agansari commented Nov 20, 2019

What's wrong with the board.cmake hook? Is it placed too early / too late ?

It's too late, my first goto was board.cmake but device tree is ready compiled before EXTRA_DTC_FLAGS is set.

SebastianBoe
SebastianBoe requested changes Nov 20, 2019
View reviewed changes
SebastianBoe
SebastianBoe reviewed Nov 20, 2019
View reviewed changes
SebastianBoe
SebastianBoe reviewed Nov 20, 2019
View reviewed changes
SebastianBoe
SebastianBoe reviewed Nov 20, 2019
View reviewed changes
@agansari
Copy link
Contributor Author

agansari commented Nov 21, 2019

@SebastianBoe @ulfalizer made the changes required, i still need to document pre_dt_board.cmake

@SebastianBoe
Copy link
Contributor

SebastianBoe commented Nov 21, 2019

@agansari : This feedback has not been addressed:

We should not use env vars to communicate information between the build system and underlying scripts. CLI arguments should be used.

@agansari agansari requested a review from dbkinder as a code owner November 28, 2019 12:26
@agansari
Copy link
Contributor Author

agansari commented Nov 29, 2019

@SebastianBoe @ulfalizer updated documentation and CLI based parameter passing

SebastianBoe
SebastianBoe reviewed Nov 29, 2019
View reviewed changes
dbkinder
dbkinder suggested changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of grammar typos

@agansari agansari requested a review from dbkinder December 11, 2019 10:26
dbkinder
dbkinder approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for doc changes, thanks!

galak
galak reviewed Jan 29, 2020
View reviewed changes
@galak galak added this to the v2.2.0 milestone Jan 29, 2020
galak
galak requested changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you look and see if we can move setting EXTRA_DTC_FLAGS in the SoC Cmake instead.

Also can you fixup the pylint error.

@agansari agansari force-pushed the warn_suppress branch 3 times, most recently from 4164de5 to 38069e5 Compare January 30, 2020 13:09
@agansari
Copy link
Contributor Author

agansari commented Jan 30, 2020

@galak fixed pylint, please review again

@agansari @galak
cmake: allow boards to have extra cmake parametes
d7b7463 
This commit allows boards to have custom cmake parameters that are
loaded before device tree is processed.

Signed-off-by: Andrei Gansari <[email protected]>
@agansari @galak
boards: suppress dtc simple_bus_reg warning on LPC
6862c25 
LPC SoCs share the same register for all GPIO poarts. This leads us to a
device tree configuration that missmatches GPIO register address and
GPIO port identifier.

Signed-off-by: Andrei Gansari <[email protected]>
@agansari @galak
cmake: pass extra dtc flags to python scripts
f5e5de0 
Pass arguments as command line from cmake to python. Extra DTC flags are
used later on to check errors in python.

Signed-off-by: Andrei Gansari <[email protected]>
@agansari @galak
scripts: simple-bus warning suppression
8f1663e 
Single-bus warning in python parsing of device tree is suppressed if
this is also suppresed in the device tree compiler.

Signed-off-by: Andrei Gansari <[email protected]>
@agansari @galak
doc: device tree - document pre_dt_board.cmake
9b823d0 
Document pre_dt_board.cmake file usage.

Signed-off-by: Andrei Gansari <[email protected]>
@galak galak merged commit 820f2bf into zephyrproject-rtos:master Feb 5, 2020
@agansari agansari deleted the warn_suppress branch February 6, 2020 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SebastianBoe SebastianBoe SebastianBoe approved these changes

@galak galak galak approved these changes

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@nashif nashif Awaiting requested review from nashif

+2 more reviewers

@ulfalizer ulfalizer ulfalizer left review comments

@dbkinder dbkinder dbkinder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area: Boards area: Build System area: Devicetree area: Documentation

Projects

None yet

Milestone

v2.2.0

Development

Successfully merging this pull request may close these issues.

build warnings on lpcxpresso54114_m0/m4 board

6 participants

@agansari @zephyrbot @SebastianBoe @ulfalizer @dbkinder @galak