Skip to content

Conversation

@carlocaione
Copy link
Contributor

DT_<COMPAT> is deprecated in favor of DT_INST. Fix that for the shared_irq driver. This is also needed if we want to manipulate the defines in the dts_fixup.h (for example if we want to offset the IRQ number in case of MULTI_LEVEL_INTERRUPTS).

Switch to the new DT_INST.

Signed-off-by: Carlo Caione <[email protected]>
@galak
Copy link
Contributor

galak commented Nov 25, 2019

@dcpleung can you take a look at this, since you made the change to use dt here: 7695a72. Would like to see this as a fix to get merged into 2.1

@galak galak added this to the v2.1.0 milestone Nov 25, 2019
@dcpleung
Copy link
Member

@dcpleung can you take a look at this, since you made the change to use dt here: 7695a72. Would like to see this as a fix to get merged into 2.1

LGTM. I don't see any boards using the shared_irq driver now, so this is not urgent. Unless @carlocaione wants this in v2.1?

@carlocaione
Copy link
Contributor Author

LGTM. I don't see any boards using the shared_irq driver now, so this is not urgent. Unless @carlocaione wants this in v2.1?

Nope. This is just a commit for a work I'm doing for 2.2. So not urgent for me.

@galak galak removed this from the v2.1.0 milestone Dec 3, 2019
@galak galak added this to the v2.2.0 milestone Dec 3, 2019
@galak galak merged commit ea9b208 into zephyrproject-rtos:master Dec 9, 2019
@carlocaione carlocaione deleted the fix_dt_shared_irq branch December 9, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants