Bluetooth: Host: Add CONFIG_BT_BONDING_REQUIRED flag #21002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demantmrrv
requested review from
Vudentz,
jhedberg and
joerchan
as code owners
Vudentz
reviewed
Nov 26, 2019
jhedberg
requested changes
Nov 26, 2019
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
demantmrrv
force-pushed
the
feature_add_bonding_required_flag
branch
from
2dee442 to
fce008b
Compare
demantmrrv
changed the title
demantmrrv
force-pushed
the
feature_add_bonding_required_flag
branch
from
fce008b to
a95b986
Compare
joerchan
suggested changes
Nov 27, 2019
Contributor
joerchan
left a comment
joerchan
left a comment
There was a problem hiding this comment.
Looks very good. Indentation should be fixed. And I gave some optional comments about style :)
demantmrrv
force-pushed
the
feature_add_bonding_required_flag
branch
from
a95b986 to
5f57335
Compare
joerchan
approved these changes
Nov 27, 2019
demantmrrv
force-pushed
the
feature_add_bonding_required_flag
branch
from
5f57335 to
9d2816b
Compare
Contributor
Author
|
Just fixed the commit message line length. |
Added configuration for accepting pairing requests only if both devices has bonding flag set in order to reject other devices at an early stage, thus leaving more chance for devices expected to bond. With the CONFIG_BT_BONDING_REQUIRED flag the device only accept pairing requests if it has CONFIG_BT_BONMDABLE set and the device requesting pairing has Bonding_Flags field set to Bonding (0x01) in its AuthReq. Note: When using bt_set_bondable(false) pairing requests will be rejected when CONFIG_BT_BONDING_REQUIRED is set. Signed-off-by: Martin Rieva <[email protected]>
demantmrrv
force-pushed
the
feature_add_bonding_required_flag
branch
from
9d2816b to
891605a
Compare
jhedberg
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added configuration for accepting pairing requests only if both devices has bonding flag set in order to reject other devices at an early stage, thus leaving more chance for devices expected to bond.
With the CONFIG_BT_BONDING_REQUIRED flag the device only accept pairing requests if it has CONFIG_BT_BONMDABLE set and the device requesting pairing has Bonding_Flags field set to Bonding (0x01) in its AuthReq.
Note: When using bt_set_bondable(false) pairing requests will be
rejected when CONFIG_BT_BONDING_REQUIRED is set.
Signed-off-by: Martin Rieva [email protected]