Bluetooth: Host: Adding valid param check in send_conn_le_param_update() #21220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
send_conn_le_param_update() when called from conn_update_timeout(), have two options. One taking the parameter values from GAP Peripheral Preferred Characteristics or from internal values. New check has been added inside send_conn_le_param_update() for the possible range of values so that in both cases we are safe by not sending the update to master if it contains values outside the range specified in Vol 3 part A section 4.20 |
Contributor
joerchan
suggested changes
Dec 6, 2019
Contributor
joerchan
left a comment
joerchan
left a comment
There was a problem hiding this comment.
Good point. But we should probably use the same check that we already have :)
subsys/bluetooth/host/conn.c
Outdated
Contributor
There was a problem hiding this comment.
Should use bt_le_conn_params_valid instead.
Contributor
Author
There was a problem hiding this comment.
Already there? Cool ! Done :)
Send connection parameter update request only if it contains the valid range of values for connection intervals, latency and timeout. Signed-off-by: Kiran Paramaswaran <[email protected]>
kipm-ot
force-pushed
the
kipm-ot-#21057
branch
from
56c7810 to
aa3d1f3
Compare
joerchan
approved these changes
Dec 6, 2019
jhedberg
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send connection parameter update request only if it contains the valid
range of values for connection intervals, latency and timeout.
Fixes: #21057
Signed-off-by: Kiran Paramaswaran [email protected]