Skip to content

Conversation

@maxvankessel
Copy link
Contributor

Split pull request, #20293.

This pr moves from the orignal pwm driver to the mfd timer.

@erwango erwango added platform: STM32 ST Micro STM32 area: PWM Pulse Width Modulation labels Dec 16, 2019
@erwango
Copy link
Member

erwango commented Dec 16, 2019

@maxvankessel, just seen this change.
Ok, let's keep it split that way.

@erwango erwango added the RFC Request For Comments: want input from the community label Dec 20, 2019
Added multi functional device driver.
Added support for new timer base (mfd stm32 timers),
which aims to be more versatile.

Signed-off-by: Max van Kessel <[email protected]>
instance 5 Seemed to have slip past

Signed-off-by: Max van Kessel <[email protected]>
Deprecation of the parent-bus and child-bus

Signed-off-by: Max van Kessel <[email protected]>
Corrected clock control include

Signed-off-by: Max van Kessel <[email protected]>
Allow usage of MFD stm32 timer as base timer for the pwm device.

Signed-off-by: Max van Kessel <[email protected]>
@zephyrbot
Copy link

Some checks failed. Please fix and resubmit.

checkpatch issues

-:111: ERROR:CODE_INDENT: code indent should use tabs where possible
#111: FILE: drivers/mfd/mfd_timer_stm32.c:50:
+                                clock_control_subsys_t *sub_system)$

-:111: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#111: FILE: drivers/mfd/mfd_timer_stm32.c:50:
+                                clock_control_subsys_t *sub_system)$

-:610: ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#610: FILE: drivers/pwm/pwm_stm32.c:26:
+	char * parent;

-:646: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#646: FILE: drivers/pwm/pwm_stm32.c:48:
+^Iconst struct pwm_stm32_config ^I*cfg = DEV_CFG(dev);$

-:647: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#647: FILE: drivers/pwm/pwm_stm32.c:49:
+^Istruct pwm_stm32_data ^I^I*data = DEV_DATA(dev);$

-:678: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#678: FILE: drivers/pwm/pwm_stm32.c:74:
+^Iconst struct pwm_stm32_config ^I*cfg = DEV_CFG(dev);$

-:679: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#679: FILE: drivers/pwm/pwm_stm32.c:75:
+^Istruct pwm_stm32_data ^I^I*data = DEV_DATA(dev);$

-:811: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#811: FILE: drivers/pwm/pwm_stm32.c:156:
+#define PWM_DEVICE_INIT_STM32(n)^I^I^I  ^I^I\$

-:812: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#812: FILE: drivers/pwm/pwm_stm32.c:157:
+static struct pwm_stm32_data pwm_stm32_dev_data_ ## n; ^I  ^I  ^I\$

-:813: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#813: FILE: drivers/pwm/pwm_stm32.c:158:
+static const struct pwm_stm32_config pwm_stm32_dev_cfg_ ## n = { ^I\$

-:818: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#818: FILE: drivers/pwm/pwm_stm32.c:163:
+};^I^I^I^I^I^I^I^I  ^I\$

-:819: ERROR:CODE_INDENT: code indent should use tabs where possible
#819: FILE: drivers/pwm/pwm_stm32.c:164:
+^I^I^I^I^I^I^I^I  ^I\$

-:819: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#819: FILE: drivers/pwm/pwm_stm32.c:164:
+^I^I^I^I^I^I^I^I  ^I\$

-:821: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#821: FILE: drivers/pwm/pwm_stm32.c:166:
+^I^I    DT_INST_## n ##_ST_STM32_PWM_LABEL,^I ^I^I\$

-:822: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#822: FILE: drivers/pwm/pwm_stm32.c:167:
+^I^I    &init,^I^I^I^I  ^I^I\$

-:823: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#823: FILE: drivers/pwm/pwm_stm32.c:168:
+^I^I    &pwm_stm32_dev_data_ ## n,^I^I^I  ^I\$

-:824: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#824: FILE: drivers/pwm/pwm_stm32.c:169:
+^I^I    &pwm_stm32_dev_cfg_ ## n,^I^I^I  ^I\$

- total: 3 errors, 14 warnings, 1319 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Codeowners issues

New files added that are not covered in CODEOWNERS:

drivers/mfd/CMakeLists.txt
drivers/mfd/Kconfig

Please add one or more entries in the CODEOWNERS file to cover those files

Nits issues

Missing newline at end of 'drivers/mfd/Kconfig'. Check your text editor settings.

Please remove blank lines at end of 'drivers/mfd/mfd_timer_stm32.c'

Missing newline at end of 'drivers/pwm/Kconfig.stm32'. Check your text editor settings.

Please remove blank lines at end of 'drivers/pwm/pwm_stm32.c'

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@github-actions github-actions bot added has-conflicts Issue/PR has conflicts with another issue/PR area: Device Tree area: Devicetree Binding PR modifies or adds a Device Tree binding labels Jun 29, 2020
@github-actions github-actions bot added has-conflicts Issue/PR has conflicts with another issue/PR and removed has-conflicts Issue/PR has conflicts with another issue/PR labels Jul 2, 2020
@nashif nashif added the Stale label Sep 4, 2020
@github-actions github-actions bot closed this Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Devicetree Binding PR modifies or adds a Device Tree binding area: Devicetree area: PWM Pulse Width Modulation has-conflicts Issue/PR has conflicts with another issue/PR platform: STM32 ST Micro STM32 RFC Request For Comments: want input from the community Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants