boards: Add support for the Serpente Board #26960

elexx · 2020-07-19T13:56:38Z

The Serpente Boards are small low-cost Atmel SAMD21 based development boards by @arturo182

Signed-off-by: Alexander Falb fal3xx@gmail.com

ioannisg

overall looks fine to me

nzmichaelh

Nice! Also check out the new seeeduino_xiao config for a more recent SAMD21 port.

boards/arm/serpente/CMakeLists.txt

boards/arm/serpente/board_init.c

boards/arm/serpente/doc/index.rst

boards/arm/serpente/serpente.dts

boards/arm/serpente/serpente.yaml

boards/arm/serpente/serpente_defconfig

elexx · 2020-07-20T18:55:11Z

Thanks for the pointers to seeeduino_xiao, I'll have a look.
Do you want me to amend to my original commit or just add a 2nd commit with the requested changes?

nzmichaelh · 2020-07-20T19:07:59Z

Thanks for the pointers to seeeduino_xiao, I'll have a look.
Do you want me to amend to my original commit or just add a 2nd commit with the requested changes?

Best practice is to amend / fixup and then do a force push. Make sure you resolve the comments first though, else Github seems to lose them.

elexx · 2020-07-22T12:29:25Z

I'm a bit lost regarding PWM.
Because the user LED is ACTIVE_LOW I'd like to set the PWM to PWM_POLARITY_INVERTED (is this the right approach?). However this does not seem to be supported by the driver or I'm doing it wrong:

pwmleds {
	compatible = "pwm-leds";
	red_led_pwm: pwm_led_0 {
		pwms = <&tcc0 0 PWM_POLARITY_INVERTED>;
	};
}

Results in errors during the build $ west build samples/basic/blinky_pwm --board=serpente -p:

[...snip...]
serpente.dts.pre.tmp:336.4-30: Warning (pwms_property): /pwmleds/pwm_led_0:pwms: cell 2 is not a phandle reference
serpente.dts.pre.tmp:335.26-337.5: Warning (pwms_property): /pwmleds/pwm_led_0: Missing property '#pwm-cells' in node /soc/interrupt-controller@e000e100 or bad phandle (referred from pwms[2])
devicetree error: <Node /soc/interrupt-controller@e000e100 in 'serpente.dts.pre.tmp'> lacks #pwm-cells
[...snip...]

elexx · 2020-07-26T06:45:12Z

PWM is now working, however the output is inverted (the LED on the Serpente is ACTIVE_LOW which is currently not supported by the DTS for SAM0-TCC-PWM). I'm working on another PR to add this feature.

nzmichaelh · 2020-07-26T07:38:18Z

PWM is now working, however the output is inverted (the LED on the Serpente is ACTIVE_HIGH which is currently not supported by the DTS for SAM0-TCC-PWM). I'm working on another PR to add this feature.

Sounds good, I was about to do the same. Let me know if you run out of time and I can take over the PWM change.

boards/arm/serpente/serpente_defconfig

elexx · 2020-07-28T05:50:18Z

The Serpente board has a very limited pin count, but the pins are well chosen. It is possible to have 2UART or 1UART+1SPI or 1I2C+1SPI or 1UART+1I2C and so on (see notes in schematics).

What is the best practice in Zephyr for the default sercom definition in the board DTS? The options I was thinking about are:

Having both available sercoms with status okay, but nothing else in the DTS + overlay for all tests. (Probably the "cleanest" and most time consuming solution I could think of)
Having some defaults like 1SPI+1I2C in the DTS + overlays for the UART tests (I'm not sure which pinout should be the default)
Remove the supported flags from yaml (This feels like a quick and dirty hack)

Are there any better ways I missed? Which one do you prefer?

samples/net/sockets/http_client/boards/serpente.overlay

vanwinkeljan

Please move serpente.overlay files in samples and tests to a separate commit as it has nothing to do with the commit boards: Add support for the Serpente Board

elexx · 2020-08-04T07:16:39Z

Please move serpente.overlay files in samples and tests to a separate commit as it has nothing to do with the commit boards: Add support for the Serpente Board

The tests and samples won't compile without warning (buildkite will fail), if I remove the overlay files. I would also have to remove the supported field from serpente.yaml, to simply not compile and tests and samples. But then the serpente.yml would not be aligned with the docs that also state what is supported by the board/mcu. I would like to keep this in one PR, but what do you think?

vanwinkeljan · 2020-08-04T07:44:30Z

The tests and samples won't compile without warning (buildkite will fail), if I remove the overlay files. I would also have to remove the supported field from serpente.yaml, to simply not compile and tests and samples. But then the serpente.yml would not be aligned with the docs that also state what is supported by the board/mcu. I would like to keep this in one PR, but what do you think?

It was just a request to move the overlays to a separate commit, not a separate PR (so one commit to introduce the board and then one commit to add the overlays)

elexx · 2020-08-04T08:23:54Z

It was just a request to move the overlays to a separate commit, not a separate PR (so one commit to introduce the board and then one commit to add the overlays)

Sorry, I misunderstood. I just splittet the commit into two.

elexx · 2020-08-04T13:58:58Z

How do you want me to proceed with the failing build_all tests? The serpente only supports 2 different interfaces out of [UART, SPI, I2C] simultaneously, but some tests use all 3 of them. What is the best practice in this scenario?

vanwinkeljan · 2020-08-05T20:28:36Z

How do you want me to proceed with the failing build_all tests? The serpente only supports 2 different interfaces out of [UART, SPI, I2C] simultaneously, but some tests use all 3 of them. What is the best practice in this scenario?

You could blacklist the board for the test that require the 3 interfaces. Have a look at tests/drivers/build_all/testcase.yaml, some of the test cases in there already blacklist (platform_exclude:) the frdm_kw41z board

elexx · 2020-08-09T16:39:52Z

I guess I messed up the review resolving. Are there still any changes pending that I missed?

Display related changes addressed

MaureenHelm · 2020-08-10T20:09:15Z

samples/display/grove_display/boards/serpente.overlay

Why aren't all these overlay settings in the main board dts? I know the sercom can be configured as i2c or uart, but once you design a board will you really switch between them?

I was debating this myself a few days ago. In the end, I choose to follow the official pinout diagram and GPIO configuration of the Serpente.
My justification for this was, that the Serpente is a quite small development/prototyping board without a specific use-case in mind. It has just a few pins which provide maximum flexibility - these exact pins are specifically choose, because they provide the most diverse config options (from PWM, touch sensitive inputs, i2c, spi to uart and so on - with only 6 pins!). I didn't want to force a default configuration on the user, which might be unexpected since the official documentation does not describe any default configs.

On the other hand I totally understand that cluttering the code with overlay files is not perfect at all. If you prefer a default configuration of the Serpente in Zephyr, maybe @arturo182 can suggest one?

@elexx put this perfectly, the idea is to not force the user into any specific configuration. TBH, it's even hard to choose which should be the default cause it totally depends on the use-case. If possible, I'd prefer we keep it as flexible as we can.

Setting these in the board dts doesn't lock a user into a specific configuration, as you can still override them in an application overlay if desired. I'm not keen on having so many overlays for this board. Can you at least put the console uart in the board dts?

Thank you for your feedback. I just added a default configuration for the zephyr console and amended the changes to my last commit.

Because I was not able to find this in the documentation or in some other SAMDx based board dts: Is it possible to use the USB connection as zephyr console by default? Without using a sercom at all? I guess this would be the preferred way for the Serpente, because it frees up 2 pins. And imho it also reduces the entry barrier for people new to Zephyr, because only one cable and no additional hardware is required to get started with Zephyr and some quick printk/log debugging.

I'm not sure if there are any boards that currently do this, but yes it should be possible. I suggest we go ahead and merge this PR, then you can submit a follow-up PR

elexx · 2020-08-13T21:07:27Z

@nzmichaelh I'm sorry, but somewhere on the way to finalize this PR it seems like I forgot to resolve a change request from you. Is there still anything you want me to fix in this PR?

Aside from that, is there anything else I can do to help finish up this PR?

MaureenHelm · 2020-08-19T16:19:07Z

@nzmichaelh please revisit

elexx · 2020-09-03T11:55:26Z

@nzmichaelh just a friendly reminder that this PR still needs your attention :-)

boards/arm/serpente/pinmux.c

@arturo182

The Serpente Boards are small low-cost Atmel SAMD21 based development boards by @arturo182 Signed-off-by: Alexander Falb <fal3xx@gmail.com>

Add the supported features section to serpente.yaml and overlay files to the corresponding tests and samples. Signed-off-by: Alexander Falb <fal3xx@gmail.com>

no response after multiple pings

elexx requested review from MaureenHelm, galak and nashif as code owners July 19, 2020 13:56

github-actions bot added area: Boards area: Devicetree area: Documentation labels Jul 19, 2020

elexx force-pushed the board/serpente branch 4 times, most recently from 4db0945 to 2d66527 Compare July 20, 2020 11:08

ioannisg added the Release Notes To be mentioned in the release notes label Jul 20, 2020

ioannisg added this to the v2.4.0 milestone Jul 20, 2020

ioannisg approved these changes Jul 20, 2020

View reviewed changes

nzmichaelh previously requested changes Jul 20, 2020

View reviewed changes

elexx force-pushed the board/serpente branch from 2d66527 to c3524cb Compare July 26, 2020 06:41

nzmichaelh reviewed Jul 26, 2020

View reviewed changes

boards/arm/serpente/serpente_defconfig Outdated Show resolved Hide resolved

elexx force-pushed the board/serpente branch from c3524cb to 47f9c8a Compare July 27, 2020 19:36

elexx force-pushed the board/serpente branch from 47f9c8a to c1ad0fb Compare July 30, 2020 22:03

elexx requested review from Mierunski, finikorg, jakub-uC, jfischer-no, jukkar and nordic-krch as code owners July 30, 2020 22:03

elexx force-pushed the board/serpente branch from c1ad0fb to 583d481 Compare July 30, 2020 22:35

jukkar reviewed Jul 31, 2020

View reviewed changes

samples/net/sockets/http_client/boards/serpente.overlay Outdated Show resolved Hide resolved

vanwinkeljan previously requested changes Aug 4, 2020

View reviewed changes

elexx force-pushed the board/serpente branch from 583d481 to c8a41f4 Compare August 4, 2020 07:28

elexx force-pushed the board/serpente branch from c8a41f4 to 7c1bddc Compare August 4, 2020 08:20

elexx requested a review from vanwinkeljan August 4, 2020 08:24

pfalcon removed their request for review August 5, 2020 08:38

elexx force-pushed the board/serpente branch from 7c1bddc to 8d49367 Compare August 9, 2020 07:50

MaureenHelm reviewed Aug 10, 2020

View reviewed changes

elexx force-pushed the board/serpente branch from 8d49367 to 8a60086 Compare August 18, 2020 07:46

MaureenHelm approved these changes Aug 19, 2020

View reviewed changes

MaureenHelm requested changes Sep 3, 2020

View reviewed changes

boards/arm/serpente/pinmux.c Outdated Show resolved Hide resolved

elexx force-pushed the board/serpente branch from 8a60086 to 09e49a4 Compare September 4, 2020 06:46

elexx added 2 commits September 4, 2020 10:38

boards: Add support for the Serpente Board

1519fab

The Serpente Boards are small low-cost Atmel SAMD21 based development boards by @arturo182 Signed-off-by: Alexander Falb <fal3xx@gmail.com>

tests/samples: add samples for Serpente board

5c20552

Add the supported features section to serpente.yaml and overlay files to the corresponding tests and samples. Signed-off-by: Alexander Falb <fal3xx@gmail.com>

elexx force-pushed the board/serpente branch from 09e49a4 to 5c20552 Compare September 4, 2020 08:39

MaureenHelm approved these changes Sep 4, 2020

View reviewed changes

MaureenHelm merged commit 402a352 into zephyrproject-rtos:master Sep 4, 2020

elexx deleted the board/serpente branch September 4, 2020 20:02

boards: Add support for the Serpente Board #26960

boards: Add support for the Serpente Board #26960

Uh oh!

Conversation

elexx commented Jul 19, 2020

Uh oh!

ioannisg left a comment

Choose a reason for hiding this comment

Uh oh!

nzmichaelh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elexx commented Jul 20, 2020

Uh oh!

nzmichaelh commented Jul 20, 2020

Uh oh!

elexx commented Jul 22, 2020

Uh oh!

elexx commented Jul 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nzmichaelh commented Jul 26, 2020

Uh oh!

Uh oh!

elexx commented Jul 28, 2020

Uh oh!

Uh oh!

vanwinkeljan left a comment

Choose a reason for hiding this comment

Uh oh!

elexx commented Aug 4, 2020

Uh oh!

vanwinkeljan commented Aug 4, 2020

Uh oh!

elexx commented Aug 4, 2020

Uh oh!

elexx commented Aug 4, 2020

Uh oh!

vanwinkeljan commented Aug 5, 2020

Uh oh!

elexx commented Aug 9, 2020

Uh oh!

MaureenHelm Aug 10, 2020

Choose a reason for hiding this comment

Uh oh!

elexx Aug 10, 2020

Choose a reason for hiding this comment

Uh oh!

arturo182 Aug 10, 2020

Choose a reason for hiding this comment

Uh oh!

MaureenHelm Aug 14, 2020

Choose a reason for hiding this comment

Uh oh!

elexx Aug 18, 2020

Choose a reason for hiding this comment

Uh oh!

MaureenHelm Aug 19, 2020

Choose a reason for hiding this comment

Uh oh!

elexx commented Aug 13, 2020

Uh oh!

MaureenHelm commented Aug 19, 2020

Uh oh!

elexx commented Sep 3, 2020

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

elexx commented Jul 26, 2020 •

edited

Loading