Reintroduce tfm-mcuboot #30614
Merged
Reintroduce tfm-mcuboot #30614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindronningstad
force-pushed
the
tfm-mcuboot
branch
from
ed2bec5 to
9c4b2d4
Compare
github-actions
bot
added
area: Modules
manifest
west
manifest-trusted-firmware-m
labels
|
The following projects have a revision update in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
tejlmand
requested changes
Dec 14, 2020
west.yml
Outdated
There was a problem hiding this comment.
We should not import from Zephyr modules from Zephyr manifest.
Please revert to the code you initially had when using Zephyr mcuboot, like you had here:
b34978f
- name: tfm-mcuboot
path: modules/tee/tfm/mcuboot
repo-path: mcuboot
revision: 1.7.0-rc1
carlescufi
requested changes
Dec 14, 2020
There was a problem hiding this comment.
As mentioned in Slack, I also agree with @tejlmand. We agreed that zephyr-specific changes and glue should stay in the main zephyr tree, and this is very much that in my opinion.
ioannisg
approved these changes
Dec 14, 2020
oyvindronningstad
force-pushed
the
tfm-mcuboot
branch
from
9c4b2d4 to
14d4fd6
Compare
carlescufi
approved these changes
Dec 14, 2020
galak
reviewed
Dec 14, 2020
oyvindronningstad
force-pushed
the
tfm-mcuboot
branch
from
14d4fd6 to
8f6d9a9
Compare
Turn on import, so tfm's west.yml is processed. Signed-off-by: Øyvind Rønningstad <[email protected]>
oyvindronningstad
force-pushed
the
tfm-mcuboot
branch
from
8f6d9a9 to
2cd39b2
Compare
|
Added comment, updated sha, and changed from |
tejlmand
approved these changes
Dec 14, 2020
|
@galak are you OK with this? |
mbolivar-nordic
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduce #30050, reverted in #30610Note that because of #30616, this now correctly runs the doc build, which passes with the addition of thewest updateline.Moved west.yml entry from module to zephyr's west.yml