Skip to content

Conversation

@auroraslb
Copy link
Contributor

This PR adds support for simulating the NRF53 network core. To be able to use bluetooth, you will need #30732.

Note: Bluetooth does not fully work, will need some help debugging this.

Copy link
Contributor

@rugeGerritsen rugeGerritsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You simplify some conditionals similar to:
defined(CONFIG_SOC_SERIES_NRF53X) || defined(CONFIG_SOC_COMPATIBLE_NRF53X_CPUNET)
by adding select SOC_COMPATIBLE_NRF53X_CPUNET to SOC_NRF5340_CPUNET inzephyr/soc/arm/nordic_nrf/nrf53/Kconfig.soc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may consider adding the remaining IRQ names as well, see nrf5340_network.h.

  • IPC
  • EGU

@galak
Copy link
Contributor

galak commented Dec 15, 2020

Is the intent to replace nrf52_bsim?

@rugeGerritsen
Copy link
Contributor

Is the intent to replace nrf52_bsim?

@galak. I would assume nrf53_bsim can be used as an addition to nrf52_bsim. The HAL is slightly different between nrf52 and nrf53 series devices. @cvinayak and @carlescufi may comment.

@galak
Copy link
Contributor

galak commented Dec 15, 2020

@galak. I would assume nrf53_bsim can be used as an addition to nrf52_bsim. The HAL is slightly different between nrf52 and nrf53 series devices. @cvinayak and @carlescufi may comment.

it would be good to explain what the difference / value is between the two. This is more about a question from a testing/ci point of view.

Update nrf_hw_models version to include nrf53 support.

Signed-off-by: Aurora Sletnes Bjørlo <[email protected]>
This folder will contain common content for both nrf52_bsim
and nrf53_cpunet_bsim.

Signed-off-by: Aurora Sletnes Bjørlo <[email protected]>
The board models the nrf53840 cpunet.

Signed-off-by: Aurora Sletnes Bjørlo <[email protected]>
Ensure correct logging of irq with nrf53.

Signed-off-by: Aurora Sletnes Bjørlo <[email protected]>
Select COMPATIBLE_NRF53X_CPUNET in SOC_NRF5340_CPUNET.
Also add defined(CONFIG_SOC_SERIES_NRF53X) where we
have defined(NRF53_SERIES).

Signed-off-by: Aurora Sletnes Bjørlo <[email protected]>
Rename nrf52_bsim to nrf5x_bsim to match with change due to
added nrf53_bsim.

Signed-off-by: Aurora Sletnes Bjørlo <[email protected]>
…_CPUNET

So that the nrfx drivers can be compiled for a simulated
nrf53 cpunet target.

Signed-off-by: Aurora Sletnes Bjørlo <[email protected]>
Add to the SOC_COMPATIBLE options a common option to choose
compatibility with a simulated BabbleSim target. Also choose
this option for the simulated targets nrf52_bsim and nrf53_cpunet_bsim.

Signed-off-by: Aurora Sletnes Bjørlo <[email protected]>
@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Apr 12, 2021
@github-actions github-actions bot closed this Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants