Skip to content

Conversation

@hakehuang
Copy link
Contributor

after 7c69934
Convert drivers to new DT device macros

now the device name is aligned with label so we need
align them to default config

Signed-off-by: Hake Huang [email protected]

@hakehuang
Copy link
Contributor Author

@MaureenHelm , this updates align for all default settings to use the right dma device name. so that DTS is aligned with config settings

@galak
Copy link
Contributor

galak commented Jan 4, 2021

No issue with the change, but curious why its needed. Is there somewhere we depend on the label name being "DMA_x"?

@hakehuang hakehuang changed the title dts: nxp edma update edma label to aligne with config setting dts: nxp edma update edma label to align with config setting Jan 8, 2021
@hakehuang
Copy link
Contributor Author

No issue with the change, but curious why its needed. Is there somewhere we depend on the label name being "DMA_x"?

@galak , this is because in dma driver test, we are using the config_dma_x, to minimum the code change, I rename the EDMA label to DAM_0 to align with the configs used.

@hakehuang hakehuang requested a review from dleach02 January 13, 2021 03:44
@hakehuang hakehuang requested a review from nashif as a code owner January 13, 2021 04:23
@github-actions github-actions bot added the area: Tests Issues related to a particular existing or missing test label Jan 13, 2021
@galak
Copy link
Contributor

galak commented Jan 13, 2021

Looks like this needs rebasing now.

after 7c69934
Convert drivers to new DT device macros

now the device name is aligned with label so we need
align them to default config

Signed-off-by: Hake Huang <[email protected]>
align test pattern with testcase.yml

Signed-off-by: Hake Huang <[email protected]>
@hakehuang hakehuang added this to the v2.5.0 milestone Jan 14, 2021
@MaureenHelm MaureenHelm merged commit f02454f into zephyrproject-rtos:master Jan 14, 2021
@MaureenHelm MaureenHelm deleted the update_edma_default_name branch January 14, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Devicetree area: Tests Issues related to a particular existing or missing test platform: NXP NXP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants