Skip to content

Conversation

@pabigot
Copy link
Contributor

@pabigot pabigot commented Jan 6, 2021

Document the use of DEVICE_DT_GET() to fetch device pointers at
compile time, and update the documentation on defining device
instances to use the devicetree macros.

Signed-off-by: Peter Bigot [email protected]

Copy link
Contributor

@mbolivar-nordic mbolivar-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing. Thanks for this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Notice the use of APIs like :c:func:`DT_INST_PROP` and
Notice the use of APIs like :c:func:`DT_PROP` and

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done; you're welcome.

@galak
Copy link
Contributor

galak commented Jan 12, 2021

@pabigot can you rebase and fix the merge conflicts now that #31108 got merged.

Document the use of DEVICE_DT_GET() to fetch device pointers at
compile time, and update the documentation on defining device
instances to use the devicetree macros.

Signed-off-by: Peter Bigot <[email protected]>
@pabigot
Copy link
Contributor Author

pabigot commented Jan 12, 2021

can you rebase and fix the merge conflicts now that #31108 got merged.

@galak done

@galak
Copy link
Contributor

galak commented Jan 12, 2021

@mbolivar-nordic any plans to introduce a helper for DT that does the DEVICE_DT_GET & device_is_ready together similar to device_get_binding?

@galak galak merged commit 92324d9 into zephyrproject-rtos:master Jan 12, 2021
@mbolivar-nordic
Copy link
Contributor

@mbolivar-nordic any plans to introduce a helper for DT that does the DEVICE_DT_GET & device_is_ready together similar to device_get_binding?

None from me. The existing APIs are good enough for what I need.

@pabigot pabigot deleted the nordic/20210106a branch January 22, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants