Skip to content

Update can_common: Check bitrate is greater than 0 #31237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2021
Merged

Update can_common: Check bitrate is greater than 0 #31237

merged 1 commit into from
Jan 12, 2021

Conversation

@eden-desta
Copy link

Ensure bitrate is greater than 0 so the program does not fault when RESET nmt command is sent

Update can_common: Check bitrate is greater than 0
98c02ea 
Ensure bitrate is greater than 0 so the program does not fault when RESET nmt command is sent
@github-actions github-actions bot added area: API Changes to public APIs area: CAN labels Jan 11, 2021
alexanderwachter
alexanderwachter approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@alexanderwachter alexanderwachter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. Indeed, not changing the bitrate when it is zero mimics the behavior of the old API. LGTM

henrikbrixandersen
henrikbrixandersen approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@henrikbrixandersen henrikbrixandersen added this to the v2.5.0 milestone Jan 11, 2021
@MaureenHelm MaureenHelm merged commit fa6ac27 into zephyrproject-rtos:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@alexanderwachter alexanderwachter alexanderwachter approved these changes

@karstenkoenig karstenkoenig Awaiting requested review from karstenkoenig

Assignees

@alexanderwachter alexanderwachter

Labels

area: API Changes to public APIs area: CAN

Projects

None yet

Milestone

v2.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@eden-desta @henrikbrixandersen @alexanderwachter @MaureenHelm