Skip to content

Conversation

@alextsam
Copy link
Contributor

This PR adds support for 2 new boards based on the nRF9160.

These two board definitions are largely similar and they are derived from the boards/arm/actinius_icarus board

Signed-off-by: Alex Tsamakos [email protected]

@alextsam
Copy link
Contributor Author

alextsam commented Feb 8, 2021

@MaureenHelm @galak @nordic-krch @jakub-uC @nashif Could you please let me know if there is something I could do to get this merged soon? Thanks a lot in advance!

@MaureenHelm
Copy link
Member

@MaureenHelm @galak @nordic-krch @jakub-uC @nashif Could you please let me know if there is something I could do to get this merged soon? Thanks a lot in advance!

@alextsam, the merge window is currently closed to new features until the v2.5.0 release is complete, which is scheduled for 12 Feb. We'll have some more bandwidth to review this after that.

@MaureenHelm MaureenHelm added this to the v2.6.0 milestone Feb 8, 2021
@alextsam
Copy link
Contributor Author

alextsam commented Feb 8, 2021

@MaureenHelm @galak @nordic-krch @jakub-uC @nashif Could you please let me know if there is something I could do to get this merged soon? Thanks a lot in advance!

@alextsam, the merge window is currently closed to new features until the v2.5.0 release is complete, which is scheduled for 12 Feb. We'll have some more bandwidth to review this after that.

@MaureenHelm Ah I was not aware of the feature window, thank you so much for the information!

@MaureenHelm
Copy link
Member

@MaureenHelm Ah I was not aware of the feature window, thank you so much for the information!

This gets announced on the mailing lists. I recommend subscribing to devel or announcements to receive future updates.

@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Apr 19, 2021
@alextsam
Copy link
Contributor Author

Could you please remove the stale label? Thank you!

@ioannisg
Copy link
Member

will take a look

Copy link
Member

@ioannisg ioannisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. @alextsam you might want to align this with the latest version of nrf1960dk_nrf9160 board definition, but that's not mandatory.

@ioannisg ioannisg requested a review from anangl May 4, 2021 13:23
@ioannisg
Copy link
Member

ioannisg commented May 4, 2021

I would also like @anangl to take a quick look.

@alextsam
Copy link
Contributor Author

alextsam commented May 4, 2021

Fine with me. @alextsam you might want to align this with the latest version of nrf1960dk_nrf9160 board definition, but that's not mandatory.

Please DNM just yet, I will align with the latest changes of the nrf9160dk_nrf9160 today
Thank you @ioannisg

@carlescufi carlescufi added the DNM This PR should not be merged (Do Not Merge) label May 5, 2021
Comment on lines 153 to 163
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why enable these HW instances without assigning any pins to them? The PWM driver will consume (when enabled in Kconfig) some RAM and flash for data structures related to those (not much but still), but they will not be very useful (pwm_pin_set_* functions will fail for them, regardless of the supplied pwm parameter).

Copy link
Member

@ioannisg ioannisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nacking temporarily, until the changes are applied

@galak
Copy link
Contributor

galak commented May 5, 2021

@alextsam any updates here. Code freeze for getting this in is on Friday May 7th.

Add support for the Actinius Icarus Bee (nRF9160).

Signed-off-by: Alex Tsamakos <[email protected]>
@alextsam alextsam force-pushed the feature/add-icarus-bee-and-som branch from 02b94bd to 090ba30 Compare May 6, 2021 07:37
alextsam added 3 commits May 6, 2021 09:43
Add configuration for the Actinius Icarus Bee in the spi_flash
and fs samples.

Signed-off-by: Alex Tsamakos <[email protected]>
Add support for the Actinius Icarus SoM (nRF9160).

Signed-off-by: Alex Tsamakos <[email protected]>
Also update the name of sram0_bsd to sram0_modem

Signed-off-by: Alex Tsamakos <[email protected]>
@alextsam alextsam force-pushed the feature/add-icarus-bee-and-som branch from 090ba30 to cc3065e Compare May 6, 2021 07:43
@alextsam
Copy link
Contributor Author

alextsam commented May 6, 2021

Thank you for your patience, should be good to go now!

@galak galak requested a review from ioannisg May 6, 2021 12:19
@ioannisg ioannisg merged commit a637f0a into zephyrproject-rtos:master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Boards area: Devicetree area: Documentation DNM This PR should not be merged (Do Not Merge)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants