-
Couldn't load subscription status.
- Fork 8.2k
boards: arm: nordic: Add BG96 to RAK5010 board #31314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
80959d7 to
e4f434d
Compare
|
Hello @galak thanks for your review and approval. I'd like to fix failing checks but I don't really understand what to do to fix this. Can you please help me on this case ? Thanks for your support |
Start by rebasing your PR, then see if any of the remaining errors are legitimate issues that need fixing. |
96ce7ee to
bc046fd
Compare
|
I suggest doing the following locally and make sure you get this to pass: Doing a quick glance at the failures, you probably need to move how you are setting CONFIG_MODEM_QUECTEL_BG9X Take a look at how its done here: boards/arm/pinnacle_100_dvk/Kconfig.defconfig |
Hello @galak thanks a lot. I will do what you suggest. I think you're right |
bc046fd to
4fe71dc
Compare
Add BG96 in board description Add W Disable Pin in BG96 descriptor Signed-off-by: Guillaume Paquet <[email protected]>
4fe71dc to
806b103
Compare
|
Looks good! Your PR will have to wait to be merged until after the 2.5 release, since we're in the stabilization period now. |
ok thanks for your feedback ;) |
Add BG96 in board description
Add W Disable Pin in BG96 descriptor