Skip to content

Conversation

@gpaquet85
Copy link
Contributor

Add BG96 in board description
Add W Disable Pin in BG96 descriptor

@gpaquet85 gpaquet85 requested a review from galak as a code owner January 14, 2021 13:46
@gpaquet85 gpaquet85 force-pushed the dev.quectel_bg96 branch 3 times, most recently from 80959d7 to e4f434d Compare January 14, 2021 14:47
@galak galak removed their assignment Jan 22, 2021
@galak galak added the platform: nRF Nordic nRFx label Jan 22, 2021
@gpaquet85
Copy link
Contributor Author

Hello @galak thanks for your review and approval. I'd like to fix failing checks but I don't really understand what to do to fix this. Can you please help me on this case ? Thanks for your support

@mbolivar-nordic
Copy link
Contributor

I'd like to fix failing checks but I don't really understand what to do to fix this.

Start by rebasing your PR, then see if any of the remaining errors are legitimate issues that need fixing.

@gpaquet85 gpaquet85 force-pushed the dev.quectel_bg96 branch 3 times, most recently from 96ce7ee to bc046fd Compare January 28, 2021 16:56
@galak
Copy link
Contributor

galak commented Jan 29, 2021

I suggest doing the following locally and make sure you get this to pass:

./scripts/twister -p rak5010_nrf52840

Doing a quick glance at the failures, you probably need to move how you are setting CONFIG_MODEM_QUECTEL_BG9X

Take a look at how its done here:

boards/arm/pinnacle_100_dvk/Kconfig.defconfig
boards/arm/particle_boron/Kconfig.defconfig

@gpaquet85
Copy link
Contributor Author

I suggest doing the following locally and make sure you get this to pass:

./scripts/twister -p rak5010_nrf52840

Doing a quick glance at the failures, you probably need to move how you are setting CONFIG_MODEM_QUECTEL_BG9X

Take a look at how its done here:

boards/arm/pinnacle_100_dvk/Kconfig.defconfig
boards/arm/particle_boron/Kconfig.defconfig

Hello @galak thanks a lot. I will do what you suggest. I think you're right

Add BG96 in board description
Add W Disable Pin in BG96 descriptor

Signed-off-by: Guillaume Paquet <[email protected]>
@gpaquet85
Copy link
Contributor Author

Hi @galak @mbolivar I think everything is cleaned from now. Let me know if any

@mbolivar-nordic
Copy link
Contributor

Looks good! Your PR will have to wait to be merged until after the 2.5 release, since we're in the stabilization period now.

@nashif nashif added this to the v2.6.0 milestone Feb 2, 2021
@gpaquet85
Copy link
Contributor Author

Looks good! Your PR will have to wait to be merged until after the 2.5 release, since we're in the stabilization period now.

ok thanks for your feedback ;)

@nashif nashif merged commit 143a776 into zephyrproject-rtos:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants