Allow DT properties to be true by default #31366
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make a string easier to read and modify in a subsequent patch. Signed-off-by: Martí Bolívar <[email protected]>
Improve a test function name. Another patch is incoming which is related to properties with default values. Signed-off-by: Martí Bolívar <[email protected]>
If an SoC has some behavior enabled by default at reset, but it can be turned off using a boolean property in DTS, users should be able to default the property to 'true' in order to make the binding behavior reflect the hardware default without having to set the property manually in each node. Signed-off-by: Martí Bolívar <[email protected]>
mbolivar-nordic
added
bug
github-actions
bot
added
the
area: Tests
Add coverage in the devicetree API for boolean properties which have default values, explicit or implicit. Signed-off-by: Martí Bolívar <[email protected]>
mbolivar-nordic
force-pushed
the
dt-prop-bool-default
branch
from
86ae00c to
7c7ae05
Compare
|
Thanks for the quick fix! I confirmed that this allows a boolean property to be default true, but it doesn't allow overriding to false in an overlay. The generated define is still 1. |
Ah, okay, that's the subtlety I was missing. I need to drop this PR then, as there's no way around that. I'll recommend a workaround in #31034. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MaureenHelm reports in #31034:
That's a bug; this is a legitimate use case.
Fix it in edtlib, adding test coverage in the C API to make sure we aren't missing anything subtle.