drivers/flash: stm32: Extend qspi-nor support to F7 series - no DMA #31409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjuul
requested review from
ABOSTM,
FRASTM,
erwango and
nashif
as code owners
github-actions
bot
added
area: Boards
area: Devicetree
area: Documentation
platform: STM32
hjuul
commented
Jan 18, 2021
erwango
requested changes
Jan 18, 2021
hjuul
force-pushed
the
stm32f7_qspi_no_dma
branch
3 times, most recently
from
eb63252 to
c132b73
Compare
erwango
approved these changes
Jan 19, 2021
FRASTM
approved these changes
Jan 26, 2021
|
@hjuul can you rebase ? |
hjuul
force-pushed
the
stm32f7_qspi_no_dma
branch
from
c132b73 to
f541d17
Compare
|
@erwango I've rebased. One of the checks are failing but I can't figure out why. Could you please have a look? |
hjuul
force-pushed
the
stm32f7_qspi_no_dma
branch
from
f541d17 to
5dc77d0
Compare
|
CI Failure: #32344 |
MaureenHelm
reviewed
Feb 22, 2021
There was a problem hiding this comment.
Is this related to qspi-nor or is it internal flash? It looks like something that might belong in a separate commit
There was a problem hiding this comment.
This part is related to internal flash. @erwango suggested I add it for consistency with other disco boards.
There was a problem hiding this comment.
I've removed the flash layout for internal flash and rebased.
gmarull
requested changes
Feb 23, 2021
There was a problem hiding this comment.
flash layout changes are not related to QSPI, so they should go into a separate commit (or even a new PR if not related/required with these changes)
hjuul
force-pushed
the
stm32f7_qspi_no_dma
branch
from
5dc77d0 to
c79fd53
Compare
MaureenHelm
approved these changes
Feb 23, 2021
gmarull
requested changes
Feb 23, 2021
Add quadspi node in stm32f7.dtsi and quadspi support to boards stm32f746g_disco and stm32f769i_disco. Note! Does not support DMA. Signed-off-by: Helge Juul <[email protected]>
hjuul
force-pushed
the
stm32f7_qspi_no_dma
branch
from
c79fd53 to
d9a45a4
Compare
gmarull
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds qspi flash support to stm32 f7. DMA is not supported (will be added in #31405).
I have verified that
samples/drivers/spi_flashworks on boards stm32f746g_disco and stm32f769i_disco.