-
Couldn't load subscription status.
- Fork 8.2k
net: socket: add SO_SNDTIMEO timeout option #31440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: socket: add SO_SNDTIMEO timeout option #31440
Conversation
|
@hubertmis: Sorry for not thanking you earlier for continuing the effort of #31369, and submitting this PR. As we now have pre-release freeze for the 2.5 release, people are concentrating on polishing it. We'll get to this PR after the release. Thanks! |
No problem, I'm aware of the ongoing release. I didn't mean to take time of any of the maintainers to look at these patches now. I'm just stacking pull requests while I'm creating patches for my project. I was expecting they'll be unstacked after release, one by one. No worries, no rush :) This particular one requires some attention. I would not merge it in current shape. We should discuss it |
|
Hello! This PR will be available soon? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hubertmis Could you fix the merge conflict and re-submit
subsys/net/lib/sockets/sockets.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one empty line is enough here.
subsys/net/lib/sockets/sockets.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this empty line can be removed
05c05fb to
45af6b8
Compare
This patch adds SO_SNDTIMEO option used to time out socket sending operations. Signed-off-by: Hubert Miś <[email protected]>
This patch adds tests for SO_SNDTIMEO socket option. Signed-off-by: Hubert Miś <[email protected]>
45af6b8 to
98371bb
Compare
This PR is intended to fix #11820.
Currently handling this option is implemented for sockets and partially for net context, but as pointed out in #31369, underlying net_context implementation of sending functions ignores timeout parameters. Because of that send timeout options is not functional yet.