Skip to content

Conversation

@hubertmis
Copy link
Member

This PR is intended to fix #11820.

Currently handling this option is implemented for sockets and partially for net context, but as pointed out in #31369, underlying net_context implementation of sending functions ignores timeout parameters. Because of that send timeout options is not functional yet.

@hubertmis hubertmis requested a review from rlubos January 20, 2021 06:26
@github-actions github-actions bot added area: API Changes to public APIs area: Networking area: Tests Issues related to a particular existing or missing test labels Jan 20, 2021
@zephyrbot zephyrbot added the area: Sockets Networking sockets label Jan 21, 2021
@pfalcon
Copy link
Contributor

pfalcon commented Feb 8, 2021

@hubertmis: Sorry for not thanking you earlier for continuing the effort of #31369, and submitting this PR. As we now have pre-release freeze for the 2.5 release, people are concentrating on polishing it. We'll get to this PR after the release. Thanks!

@pfalcon pfalcon added this to the v2.6.0 milestone Feb 8, 2021
@hubertmis
Copy link
Member Author

As we now have pre-release freeze for the 2.5 release, people are concentrating on polishing it. We'll get to this PR after the release.

No problem, I'm aware of the ongoing release. I didn't mean to take time of any of the maintainers to look at these patches now. I'm just stacking pull requests while I'm creating patches for my project. I was expecting they'll be unstacked after release, one by one.

No worries, no rush :)

This particular one requires some attention. I would not merge it in current shape. We should discuss it

@expploitt
Copy link

Hello! This PR will be available soon? Thanks!

Copy link
Member

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hubertmis Could you fix the merge conflict and re-submit

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one empty line is enough here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this empty line can be removed

This patch adds SO_SNDTIMEO option used to time out socket sending
operations.

Signed-off-by: Hubert Miś <[email protected]>
This patch adds tests for SO_SNDTIMEO socket option.

Signed-off-by: Hubert Miś <[email protected]>
@jukkar jukkar merged commit ca87d13 into zephyrproject-rtos:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: API Changes to public APIs area: Networking area: Sockets Networking sockets area: Tests Issues related to a particular existing or missing test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sockets: Implement (POSIX-compatible) timeout support

7 participants