Skip to content

can:mcux_flexcan driver errata #31730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2021
Merged

can:mcux_flexcan driver errata #31730

merged 1 commit into from
Feb 1, 2021

Conversation

@hakehuang
Copy link
Contributor

in NXP flexcan driver we need add ERRATA for
ERRATA 5461 and 5829, reproted in #31555

Signed-off-by: Hake Huang [email protected]

@hakehuang hakehuang added this to the v2.5.0 milestone Jan 28, 2021
@hakehuang hakehuang self-assigned this Jan 28, 2021
@hakehuang
Copy link
Contributor Author

for tests/drivers/can/api

*** Booting Zephyr OS build v2.5.0-rc1-107-gaf67564573f5  ***
Running test suite can_driver
===================================================================
START - test_set_loopback
 PASS - test_set_loopback
===================================================================
START - test_send_and_forget
 PASS - test_send_and_forget
===================================================================
START - test_filter_attach
 PASS - test_filter_attach
===================================================================
START - test_receive_timeout
 PASS - test_receive_timeout
===================================================================
START - test_send_callback
 PASS - test_send_callback
===================================================================
START - test_send_receive_std
 PASS - test_send_receive_std
===================================================================
START - test_send_receive_ext
 PASS - test_send_receive_ext
===================================================================
START - test_send_receive_std_masked
 PASS - test_send_receive_std_masked
===================================================================
START - test_send_receive_ext_masked
 PASS - test_send_receive_ext_masked
===================================================================
START - test_send_receive_buffer
 PASS - test_send_receive_buffer
===================================================================
START - test_send_receive_wrong_id
 PASS - test_send_receive_wrong_id
===================================================================
START - test_send_invalid_dlc
E: DLC of 9 exceeds maximum (8)
 PASS - test_send_invalid_dlc
===================================================================
Test suite can_driver succeeded
===================================================================
PROJECT EXECUTION SUCCESSFUL

@hakehuang hakehuang linked an issue Jan 28, 2021 that may be closed by this pull request
tests:drivers_can_api: mimxrt1060 can api test meet assert failure #31555
Closed
@hakehuang hakehuang mentioned this pull request Jan 28, 2021
Closed
@hakehuang hakehuang requested a review from nashif as a code owner January 28, 2021 10:50
@github-actions github-actions bot added the area: Tests Issues related to a particular existing or missing test label Jan 28, 2021
@hakehuang
Copy link
Contributor Author

hakehuang commented Jan 28, 2021 •
edited
Loading 

*** Booting Zephyr OS build v2.5.0-rc1-108-ga3c2e2f92091  ***
Running test suite isotp_conformance
===================================================================
START - test_send_sf
 PASS - test_send_sf
===================================================================
START - test_receive_sf
I: SF DL does not match. Ignore
I: SF DL does not match. Ignore
 PASS - test_receive_sf
===================================================================
START - test_send_sf_ext
 PASS - test_send_sf_ext
===================================================================
START - test_receive_sf_ext
I: SF DL does not match. Ignore
I: SF DL does not match. Ignore
 PASS - test_receive_sf_ext
===================================================================
START - test_send_data
 PASS - test_send_data
===================================================================
START - test_send_data_blocks
 PASS - test_send_data_blocks
===================================================================
START - test_receive_data
 PASS - test_receive_data
===================================================================
START - test_receive_data_blocks
 PASS - test_receive_data_blocks
===================================================================
START - test_send_timeouts
E: Reception of next FC has timed out
E: Reception of next FC has timed out
E: Reception of next FC has timed out
 PASS - test_send_timeouts
===================================================================
START - test_receive_timeouts
E: Timeout while waiting for CF
 PASS - test_receive_timeouts
===================================================================
START - test_stmin
 PASS - test_stmin
===================================================================
START - test_receiver_fc_errors
E: Sequence number missmatch
I: Got unexpected frame. Ignore
I: Got unexpected frame. Ignore
I: Got unexpected frame. Ignore
I: Got unexpected frame. Ignore
I: Got unexpected frame. Ignore
I: Got unexpected frame. Ignore
 PASS - test_receiver_fc_errors
===================================================================
START - test_sender_fc_errors
E: Pkt length is 5118 but buffer has only 768 bytes
E: Got overflow FC frame
E: Got overflow FC frame
I: Got to many wait frames
 PASS - test_sender_fc_errors
===================================================================
Test suite isotp_conformance succeeded
===================================================================
PROJECT EXECUTION SUCCESSFUL
W: Bitrate error: 40
*** Booting Zephyr OS build v2.5.0-rc1-108-ga3c2e2f92091  ***
Running test suite isotp_conformance
===================================================================
START - test_send_sf
 PASS - test_send_sf
===================================================================
START - test_receive_sf
I: SF DL does not match. Ignore
I: SF DL does not match. Ignore
 PASS - test_receive_sf
===================================================================
START - test_send_sf_ext
 PASS - test_send_sf_ext
===================================================================
START - test_receive_sf_ext
I: SF DL does not match. Ignore
I: SF DL does not match. Ignore
 PASS - test_receive_sf_ext
===================================================================
START - test_send_data
 PASS - test_send_data
===================================================================
START - test_send_data_blocks
 PASS - test_send_data_blocks
===================================================================
START - test_receive_data
 PASS - test_receive_data
===================================================================
START - test_receive_data_blocks
 PASS - test_receive_data_blocks
===================================================================
START - test_send_timeouts
E: Reception of next FC has timed out
E: Reception of next FC has timed out
E: Reception of next FC has timed out
 PASS - test_send_timeouts
===================================================================
START - test_receive_timeouts
E: Timeout while waiting for CF
 PASS - test_receive_timeouts
===================================================================
START - test_stmin
 PASS - test_stmin
===================================================================
START - test_receiver_fc_errors
E: Sequence number missmatch
I: Got unexpected frame. Ignore
I: Got unexpected frame. Ignore
I: Got unexpected frame. Ignore
I: Got unexpected frame. Ignore
I: Got unexpected frame. Ignore
I: Got unexpected frame. Ignore
 PASS - test_receiver_fc_errors
===================================================================
START - test_sender_fc_errors
E: Pkt length is 5118 but buffer has only 768 bytes
E: Got overflow FC frame
E: Got overflow FC frame
I: Got to many wait frames
 PASS - test_sender_fc_errors
===================================================================
Test suite isotp_conformance succeeded
===================================================================
PROJECT EXECUTION SUCCESSFUL

@hakehuang hakehuang linked an issue Jan 28, 2021 that may be closed by this pull request
tests:subsys_canbus_isotp: mimxrt1060 meet recv timeout #31741
Closed
@hakehuang
Copy link
Contributor Author

isotp_implement log

*** Booting Zephyr OS build v2.5.0-rc1-109-gaee9e6364e3f  ***
Running test suite isotp
===================================================================
START - test_bind_unbind
 PASS - test_bind_unbind
===================================================================
START - test_send_receive_net_sf
 PASS - test_send_receive_net_sf
===================================================================
START - test_send_receive_net_blocks
 PASS - test_send_receive_net_blocks
===================================================================
START - test_send_receive_net_single_blocks
 PASS - test_send_receive_net_single_blocks
===================================================================
START - test_send_receive_sf
 PASS - test_send_receive_sf
===================================================================
START - test_send_receive_blocks
 PASS - test_send_receive_blocks
===================================================================
START - test_send_receive_single_block
 PASS - test_send_receive_single_block
===================================================================
START - test_buffer_allocation
 PASS - test_buffer_allocation
===================================================================
START - test_buffer_allocation_wait
 PASS - test_buffer_allocation_wait
===================================================================
Test suite isotp succeeded
===================================================================
PROJECT EXECUTION SUCCESSFUL

henrikbrixandersen
henrikbrixandersen approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MaureenHelm
MaureenHelm reviewed Jan 28, 2021
View reviewed changes
Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hakehuang !

The fix looks good, but please address the compliance failure (leading space).

@nashif the doc failure looks unrelated

@hakehuang
Copy link
Contributor Author

Thanks @hakehuang !

The fix looks good, but please address the compliance failure (leading space).

thanks maureen. updated

@hakehuang
drivers: mcux_flexcan driver errata
6dc7c65 
in NXP flexcan driver we need add ERRATA for
ERRATA 5461 and 5829, reproted in #31555

Signed-off-by: Hake Huang <[email protected]>
alexanderwachter
alexanderwachter requested changes Jan 29, 2021
View reviewed changes
tests/subsys/canbus/isotp/conformance/src/main.c Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this change. We have another PR that will fix it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexanderwachter Can you give a link to that PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#31078

@alexanderendian and @MaureenHelm I remove this fixes, Thanks

MaureenHelm
MaureenHelm approved these changes Jan 29, 2021
View reviewed changes
tests/subsys/canbus/isotp/conformance/src/main.c Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexanderwachter Can you give a link to that PR?

@alexanderwachter
Copy link
Member

alexanderwachter commented Jan 29, 2021 •
edited
Loading

#31078

@nashif nashif merged commit a50b69d into zephyrproject-rtos:master Feb 1, 2021
@MaureenHelm MaureenHelm deleted the flexcan_errata_fix branch February 1, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@alexanderwachter alexanderwachter alexanderwachter approved these changes

@nashif nashif Awaiting requested review from nashif

Assignees

@hakehuang hakehuang

Labels

area: CAN area: Tests Issues related to a particular existing or missing test platform: NXP NXP

Projects

None yet

Milestone

v2.5.0

Development

Successfully merging this pull request may close these issues.

tests:subsys_canbus_isotp: mimxrt1060 meet recv timeout tests:drivers_can_api: mimxrt1060 can api test meet assert failure

5 participants

@hakehuang @alexanderwachter @henrikbrixandersen @MaureenHelm @nashif