Skip to content

sys: util: Add fast version of FOR_EACH_x, GET_ARG and GET_ARGS_LESS #31904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 23, 2021
Merged

sys: util: Add fast version of FOR_EACH_x, GET_ARG and GET_ARGS_LESS #31904

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f911bbc
sys: util: Update implementation of loop macros
nordic-krch Feb 17, 2021
ee4feef
tests: unit: util: Add test for REVERSE_ARGS
nordic-krch Feb 17, 2021
0b6845f
tests: unit: util: Extended UTIL_LISTIFY test
nordic-krch Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/unit/util/test.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,9 @@ void test_UTIL_LISTIFY(void)
{
int i = 0;

#define INC(x, _) \
#define INC(x, n, m) \
do { \
i += x; \
i += (x + n + m);\
} while (0);

#define DEFINE(x, y) int a##x = x * y;
Expand All @@ -177,9 +177,9 @@ void test_UTIL_LISTIFY(void)
UTIL_LISTIFY(4, DEFINE, 2)
UTIL_LISTIFY(4, MARK_UNUSED, _)

UTIL_LISTIFY(4, INC, _)
UTIL_LISTIFY(4, INC, 1, 2)

zassert_equal(i, 0 + 1 + 2 + 3, NULL);
zassert_equal(i, 0 + 1 + 2 + 3 + 4 * (1 + 2), NULL);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a little more clear expressed as:

zassert_equal(i, (0 + 1 + 2) + (1 + 1 + 2) + (2 + 1 + 2) + (3 + 1 + 2), NULL);

since that represents the effect of the four calls.

zassert_equal(a0, 0, NULL);
zassert_equal(a1, 2, NULL);
zassert_equal(a2, 4, NULL);
Expand Down