Skip to content

Iis2iclx sensor: move odr and range into dts #32168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 15, 2021
Merged

Iis2iclx sensor: move odr and range into dts #32168

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f02e710
dts/bindings: iis2iclx: create a common st,iis2iclx-common.yaml
avisconti Feb 5, 2021
450c61c
drivers/sensor: iis2iclx: Move range Kconfig property into dts
avisconti Feb 5, 2021
85353d0
drivers/sensor: iis2iclx: Move odr Kconfig property into dts
avisconti Feb 9, 2021
d144f64
drivers/sensor: iis2iclx: modify int-pin type in DT
avisconti Feb 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions dts/bindings/sensor/st,iis2iclx-common.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Copyright (c) 2020 STMicroelectronics
# SPDX-License-Identifier: Apache-2.0

properties:
drdy-gpios:
type: phandle-array
required: false
description: DRDY pin

This pin defaults to active high when produced by the sensor.
The property value should ensure the flags properly describe
the signal that is presented to the driver.

int-pin:
type: int
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's out of the PR's intended scope, and the same problem occurs elsewhere so won't block on this, but:

In another PR please review all uses of similar properties in ST devicetree bindings and make this and the others you'll find an enum too, like st,iis2dlpc's drdy-int property.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pabigot
Yes, that's a good point. I'll do it in a separate PR.
Thanks

required: false
default: 1
description: Device INT pin number (1 or 2)

This number represents which of the two interrupt pins
(INT1 or INT2) the line is attached to. This property is not
mandatory and if not present it defaults to 1.
22 changes: 1 addition & 21 deletions dts/bindings/sensor/st,iis2iclx-i2c.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,24 +7,4 @@ description: |

compatible: "st,iis2iclx"

include: i2c-device.yaml

properties:
drdy-gpios:
type: phandle-array
required: false
description: DRDY pin

This pin defaults to active high when produced by the sensor.
The property value should ensure the flags properly describe
the signal that is presented to the driver.

int-pin:
type: int
required: false
default: 1
description: Device INT pin number (1 or 2)

This number represents which of the two interrupt pins
(INT1 or INT2) the line is attached to. This property is not
mandatory and if not present it defaults to 1.
include: ["i2c-device.yaml", "st,iis2iclx-common.yaml"]
22 changes: 1 addition & 21 deletions dts/bindings/sensor/st,iis2iclx-spi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,24 +7,4 @@ description: |

compatible: "st,iis2iclx"

include: spi-device.yaml

properties:
drdy-gpios:
type: phandle-array
required: false
description: DRDY pin

This pin defaults to active high when produced by the sensor.
The property value should ensure the flags properly describe
the signal that is presented to the driver.

int-pin:
type: int
required: false
default: 1
description: Device INT pin number (1 or 2)

This number represents which of the two interrupt pins
(INT1 or INT2) the line is attached to. This property is not
mandatory and if not present it defaults to 1.
include: ["spi-device.yaml", "st,iis2iclx-common.yaml"]