sys: util: Update implementation of loop macros #32692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recursive macros are more generic but they are very depending for preprocessor. When they are used extensively they can prolong compilation even ten times. Replaced them with brute force implementation for: - FOR_EACH macros - GET_N_ARG - GET_ARGS_LESS_N - UTIL_LISTIFY - UTIL_REPEAT New implementation provides same functionality but it is limited to 64 input arguments. This is not a hard limitation and can be increased in the future. Signed-off-by: Krzysztof Chruscinski <[email protected]>
nordic-krch
requested review from
MaureenHelm,
carlescufi,
galak and
nashif
as code owners
mbolivar-nordic
approved these changes
Feb 26, 2021
jukkar
approved these changes
Feb 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing back reverted commit, Commit was initially introduced by #31904 and then reverted by #32645.
The reason for sample failing was that macro
#define UTIL_EXPAND(...) __VA_ARGS__was accidentally removed fromutil_internal.hand it was used by usb audio. Missing macro was added back toutil_internal.h. No other changes compared to initial commit.Fixes #32619.
Signed-off-by: Krzysztof Chruscinski [email protected]