Post merge VOCS fixes #33616
Merged
Post merge VOCS fixes #33616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was requested in the review for ed2162c but was merged before it could be fixed. Signed-off-by: Emil Gydesen <[email protected]>
VOCS does not support the write long procedure, and thus should not accept any offset in write requests. Signed-off-by: Emil Gydesen <[email protected]>
Add casting to (void) to explicitely ignore the return value of the notifi function calls. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
requested review from
Vudentz,
asbjornsabo,
jhedberg and
joerchan
as code owners
joerchan
approved these changes
Mar 23, 2021
jhedberg
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues raised by @joerchan in #31893 (comment) that was not fixed before the PR was merged.