twister: check if qemu is executable #35424
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangnuannuan
force-pushed
the
jingru-qemu-children-process-clean
branch
from
98ddebb to
d811de6
Compare
wangnuannuan
force-pushed
the
jingru-qemu-children-process-clean
branch
from
d811de6 to
0452fe4
Compare
wangnuannuan
changed the title
wangnuannuan
force-pushed
the
jingru-qemu-children-process-clean
branch
2 times, most recently
from
9d65b3a to
86586e4
Compare
galak
reviewed
May 19, 2021
zephyrbot
requested review from
PerMac,
chen-png,
enjiamai,
hakehuang and
jocelyn-li
hakehuang
approved these changes
May 20, 2021
scripts/pylib/twister/twisterlib.py
Outdated
There was a problem hiding this comment.
in what situation qemu binary is not exist or not executable?
There was a problem hiding this comment.
Previously, to get the SDK, I copied it directly from another machine. In which case twister would hang forever without any error message, I spent a lot of time to find out the root cause ( I didn't try to run case with west), finanlly I found qemu binary didn't work. So I think it's necessay to verify the qemu binary in twister
There was a problem hiding this comment.
in this case, it is a false operation, it is better to return error, not skip
wangnuannuan
force-pushed
the
jingru-qemu-children-process-clean
branch
2 times, most recently
from
2495c9b to
59bf3c9
Compare
tejlmand
approved these changes
May 26, 2021
hakehuang
approved these changes
May 26, 2021
wangnuannuan
force-pushed
the
jingru-qemu-children-process-clean
branch
2 times, most recently
from
3507338 to
a610344
Compare
When the qemu binary file doesn't exist or it is unexecutable, the twister can't detect this error then the twister will hang forever. Signed-off-by: Jingru Wang <[email protected]>
wangnuannuan
force-pushed
the
jingru-qemu-children-process-clean
branch
from
a610344 to
625411c
Compare
|
#36257 also can handle this problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the qemu binary file doesn't exist or it is unexecutable, cmake will not throw error message, also the twister can't
detect this error, then the twister will hang forever
#35386
Signed-off-by: Jingru Wang [email protected]